Skip to content

Commit 85fb767

Browse files
author
Andrei Neagu
committed
fixed tests
1 parent 4abd21a commit 85fb767

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

services/storage/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ async def delete_directory(
633633
client: httpx.AsyncClient,
634634
user_id: UserID,
635635
location_id: LocationID,
636-
) -> Callable[..., Awaitable[None]]:
636+
) -> Callable[[StorageFileID], Awaitable[None]]:
637637
async def _dir_remover(directory_s3: StorageFileID) -> None:
638638
delete_url = url_from_operation_id(
639639
client,

services/storage/tests/unit/test_simcore_s3_dsm.py

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,10 @@
99

1010
import pytest
1111
from faker import Faker
12-
from models_library.api_schemas_storage.storage_schemas import FileUploadSchema
1312
from models_library.basic_types import SHA256Str
1413
from models_library.progress_bar import ProgressReport
1514
from models_library.projects import ProjectID
16-
from models_library.projects_nodes_io import NodeID, SimcoreS3FileID
15+
from models_library.projects_nodes_io import NodeID, SimcoreS3FileID, StorageFileID
1716
from models_library.users import UserID
1817
from pydantic import ByteSize, TypeAdapter
1918
from pytest_mock import MockerFixture
@@ -25,7 +24,10 @@
2524
from simcore_service_storage.simcore_s3_dsm import SimcoreS3DataManager
2625
from sqlalchemy.ext.asyncio import AsyncEngine
2726

28-
pytest_simcore_core_services_selection = ["postgres"]
27+
pytest_simcore_core_services_selection = [
28+
"postgres",
29+
"rabbit",
30+
]
2931
pytest_simcore_ops_services_selection = ["adminer"]
3032

3133

@@ -169,14 +171,14 @@ async def paths_for_export(
169171
[ByteSize, str, ProjectID, NodeID, int, int],
170172
Awaitable[tuple[NodeID, dict[SimcoreS3FileID, FileIDDict]]],
171173
],
172-
delete_directory: Callable[..., Awaitable[None]],
174+
delete_directory: Callable[[StorageFileID], Awaitable[None]],
173175
project_id: ProjectID,
174176
node_id: NodeID,
175177
) -> AsyncIterable[set[SimcoreS3FileID]]:
176178
dir_name = "data_to_export"
177179

178-
directory_file_upload: FileUploadSchema = await create_empty_directory(
179-
dir_name=dir_name
180+
directory_file_upload: SimcoreS3FileID = await create_empty_directory(
181+
dir_name, project_id, node_id
180182
)
181183

182184
upload_result: tuple[NodeID, dict[SimcoreS3FileID, FileIDDict]] = (
@@ -194,7 +196,7 @@ async def paths_for_export(
194196

195197
yield set(uploaded_files_data.keys())
196198

197-
await delete_directory(directory_file_upload=directory_file_upload)
199+
await delete_directory(directory_file_upload)
198200

199201

200202
def _get_folder_and_files_selection(
@@ -227,6 +229,12 @@ async def _assert_meta_data_entries_count(
227229
assert len(result) == count
228230

229231

232+
@pytest.mark.parametrize(
233+
"location_id",
234+
[SimcoreS3DataManager.get_location_id()],
235+
ids=[SimcoreS3DataManager.get_location_name()],
236+
indirect=True,
237+
)
230238
async def test_create_s3_export(
231239
simcore_s3_dsm: SimcoreS3DataManager,
232240
user_id: UserID,

0 commit comments

Comments
 (0)