Skip to content

Commit 86019e4

Browse files
adding unit test
1 parent bb8a6c2 commit 86019e4

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/services/modules/db/credit_transactions_db.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ async def get_transaction_current_credits_by_service_run_id(
222222
) -> Decimal:
223223
async with transaction_context(engine, connection) as conn:
224224
select_stmt = sa.select(
225-
resource_tracker_credit_transactions.c.transaction_id
225+
resource_tracker_credit_transactions.c.osparc_credits
226226
).where(
227227
resource_tracker_credit_transactions.c.service_run_id == f"{service_run_id}"
228228
)

services/resource-usage-tracker/tests/unit/with_dbs/test_api_service_runs__list_billable.py

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from collections.abc import Iterator
22
from datetime import datetime, timedelta, timezone
3+
from decimal import Decimal
34

45
import pytest
56
import sqlalchemy as sa
@@ -14,7 +15,10 @@
1415
from models_library.rest_ordering import OrderBy, OrderDirection
1516
from servicelib.rabbitmq import RabbitMQRPCClient
1617
from servicelib.rabbitmq._errors import RPCServerError
17-
from servicelib.rabbitmq.rpc_interfaces.resource_usage_tracker import service_runs
18+
from servicelib.rabbitmq.rpc_interfaces.resource_usage_tracker import (
19+
credit_transactions,
20+
service_runs,
21+
)
1822
from simcore_postgres_database.models.resource_tracker_credit_transactions import (
1923
resource_tracker_credit_transactions,
2024
)
@@ -111,8 +115,20 @@ async def test_rpc_list_service_runs_which_was_billed(
111115

112116
assert len(result.items) == 2
113117
assert result.total == 2
114-
assert result.items[0].credit_cost < 0
118+
_get_credit_cost = result.items[0].credit_cost
119+
assert _get_credit_cost
120+
assert _get_credit_cost < 0
115121
assert result.items[0].transaction_status in list(CreditTransactionStatus)
122+
_get_service_run_id = result.items[0].service_run_id
123+
124+
result = (
125+
await credit_transactions.get_transaction_current_credits_by_service_run_id(
126+
rpc_client,
127+
service_run_id=_get_service_run_id,
128+
)
129+
)
130+
assert isinstance(result, Decimal)
131+
assert result == _get_credit_cost
116132

117133

118134
@pytest.mark.rpc_test()

0 commit comments

Comments
 (0)