continue fixing

Author: giancarloromeo

services/director-v2/src/simcore_service_director_v2/cli/_close_and_save_service.py

@@ -106,7 +106,7 @@ async def async_close_and_save_service(
         client = Client(
             app=app,
             async_client=thin_dv2_localhost_client.client,
-            base_url=TypeAdapter(AnyHttpUrl).validate_python(thin_dv2_localhost_client.BASE_ADDRESS),
+            base_url=f"{TypeAdapter(AnyHttpUrl).validate_python(thin_dv2_localhost_client.BASE_ADDRESS)}",
         )
 
         if not skip_container_removal:

services/director-v2/src/simcore_service_director_v2/models/dynamic_services_scheduler.py

@@ -127,8 +127,8 @@ class DockerContainerInspect(BaseModel):
 
     @cached_property
     def status(self) -> DockerStatus:
-        assert self.container_state.Status  # nosec
-        result: DockerStatus = self.container_state.Status
+        assert self.container_state.status  # nosec
+        result: DockerStatus = self.container_state.status
         return result
 
     @classmethod
@@ -198,7 +198,7 @@ class DynamicSidecar(BaseModel):
 
     is_ready: bool = Field(
         default=False,
-        scription=(
+        description=(
             "is True while the health check on the dynamic-sidecar is responding. "
             "Meaning that the dynamic-sidecar is reachable and can accept requests"
         ),
@@ -220,7 +220,7 @@ def compose_spec_submitted(self) -> bool:
 
     containers_inspect: list[DockerContainerInspect] = Field(
         [],
-        scription="docker inspect results from all the container ran at regular intervals",
+        description="docker inspect results from all the container ran at regular intervals",
     )
 
     was_dynamic_sidecar_started: bool = False

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/errors.py

@@ -1,6 +1,6 @@
 from aiodocker.exceptions import DockerError
+from common_library.errors_classes import OsparcErrorMixin
 from models_library.projects_nodes_io import NodeID
-from pydantic.errors import PydanticErrorMixin
 
 from ...core.errors import DirectorError
 
@@ -39,6 +39,6 @@ class LegacyServiceIsNotSupportedError(DirectorError):
     """This API is not implemented by the director-v0"""
 
 
-class UnexpectedContainerStatusError(PydanticErrorMixin, DynamicSidecarError):
+class UnexpectedContainerStatusError(OsparcErrorMixin, DynamicSidecarError):
     code = "dynamic_sidecar.container_status"
     msg_template = "Unexpected status from containers: {containers_with_error}"