fix url

Author: giancarloromeo

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/api_client/_thin.py

@@ -63,13 +63,13 @@ def _get_url(
         no_api_version: bool = False,
     ) -> str:
         """formats and returns an url for the request"""
-        api_version = "" if no_api_version else f"/{self.API_VERSION}"
+        api_version = "" if no_api_version else f"{self.API_VERSION}/"
         return f"{dynamic_sidecar_endpoint}{api_version}{postfix}"
 
     async def _get_health_common(
         self, dynamic_sidecar_endpoint: AnyHttpUrl
     ) -> Response:
-        url = self._get_url(dynamic_sidecar_endpoint, "/health", no_api_version=True)
+        url = self._get_url(dynamic_sidecar_endpoint, "health", no_api_version=True)
         return await self.client.get(url, timeout=self._health_request_timeout)
 
     @retry_on_errors()
@@ -88,7 +88,7 @@ async def get_health_no_retry(
     async def get_containers(
         self, dynamic_sidecar_endpoint: AnyHttpUrl, *, only_status: bool
     ) -> Response:
-        url = self._get_url(dynamic_sidecar_endpoint, "/containers")
+        url = self._get_url(dynamic_sidecar_endpoint, "containers")
         return await self.client.get(url, params={"only_status": only_status})
 
     @retry_on_errors()

services/director-v2/tests/unit/test_modules_dynamic_sidecar_client_api_thin.py

@@ -116,7 +116,7 @@ async def test_get_containers(
     mock_response = Response(status.HTTP_200_OK)
     mock_request(
         "GET",
-        f"{dynamic_sidecar_endpoint}/{thin_client.API_VERSION}/containers?only_status={str(only_status).lower()}",
+        f"{dynamic_sidecar_endpoint}{thin_client.API_VERSION}/containers?only_status={str(only_status).lower()}",
         mock_response,
         None,
     )