mypy

Author: sanderegg

services/storage/src/simcore_service_storage/modules/celery/_task.py

@@ -1,4 +1,5 @@
 import asyncio
+import inspect
 import logging
 import traceback
 from collections.abc import Callable, Coroutine
@@ -94,18 +95,23 @@ def define_task(
 ) -> None: ...
 
 
-def define_task(
+def define_task(  # type: ignore[misc]
     app: Celery,
     fn: (
         Callable[Concatenate[Task, TaskId, P], Coroutine[Any, Any, R]]
         | Callable[Concatenate[Task, P], R]
     ),
     task_name: str | None = None,
-):
-    wrapped_fn = error_handling(fn)
+) -> None:
+    """Decorator to define a celery task with error handling and abortable support"""
+    wrapped_fn: Callable[Concatenate[Task, P], R]
     if asyncio.iscoroutinefunction(fn):
         wrapped_fn = _async_task_wrapper(app)(fn)
+    else:
+        assert inspect.isfunction(fn)  # nosec
+        wrapped_fn = fn
 
+    wrapped_fn = error_handling(wrapped_fn)
     app.task(
         name=task_name or fn.__name__,
         bind=True,