fixed unused

Author: Andrei Neagu

services/director-v2/src/simcore_service_director_v2/modules/catalog.py

@@ -117,7 +117,7 @@ async def get_service_labels(
         )
         resp.raise_for_status()
         if resp.status_code == status.HTTP_200_OK:
-            return SimcoreServiceLabels.model_validate(resp)
+            return SimcoreServiceLabels.model_validate(resp.json())
         raise HTTPException(status_code=resp.status_code, detail=resp.content)
 
     async def get_service_specifications(

services/director-v2/tests/unit/test_modules_dynamic_sidecar_scheduler.py

@@ -5,7 +5,6 @@
 
 import logging
 import re
-import urllib.parse
 from collections.abc import AsyncGenerator, Awaitable, Callable, Iterator
 from contextlib import asynccontextmanager, contextmanager
 from typing import Final
@@ -18,14 +17,12 @@
 from models_library.api_schemas_directorv2.dynamic_services_service import (
     RunningDynamicServiceDetails,
 )
-from models_library.service_settings_labels import SimcoreServiceLabels
 from models_library.services_enums import ServiceState
 from models_library.wallets import WalletID
 from pydantic import NonNegativeFloat
 from pytest_mock.plugin import MockerFixture
 from pytest_simcore.helpers.typing_env import EnvVarsDict
 from respx.router import MockRouter
-from simcore_service_director_v2.core.settings import AppSettings
 from simcore_service_director_v2.models.dynamic_services_scheduler import (
     DockerContainerInspect,
     DynamicSidecarStatus,
@@ -149,24 +146,6 @@ def mock_env(
     monkeypatch.setenv("S3_BUCKET_NAME", faker.pystr())
 
 
-@pytest.fixture
-def mocked_director_v0(
-    minimal_config: AppSettings, scheduler_data: SchedulerData
-) -> Iterator[MockRouter]:
-    endpoint = minimal_config.DIRECTOR_V0.endpoint
-
-    with respx.mock as mock:
-        mock.get(
-            re.compile(
-                rf"^{endpoint}/services/{urllib.parse.quote_plus(scheduler_data.key)}/{scheduler_data.version}/labels"
-            ),
-            name="service labels",
-        ).respond(
-            json={"data": SimcoreServiceLabels.model_json_schema()["examples"][0]}
-        )
-        yield mock
-
-
 @pytest.fixture
 def mocked_dynamic_scheduler_events(mocker: MockerFixture) -> None:
     class AlwaysTriggersDynamicSchedulerEvent(DynamicSchedulerEvent):

services/director-v2/tests/unit/with_dbs/test_api_route_dynamic_services.py

@@ -238,12 +238,6 @@ def mocked_director_v0_service_api(
         assert_all_called=False,
         assert_all_mocked=True,
     ) as respx_mock:
-        # get services labels
-        respx_mock.get(
-            f"/services/{urllib.parse.quote_plus(service['key'])}/{service['version']}/labels",
-            name="service labels",
-        ).respond(json={"data": service_labels})
-
         respx_mock.get(
             f"/running_interactive_services/{service['node_uuid']}",
             name="running interactive service",