fix mypy

Author: giancarloromeo

services/web/server/src/simcore_service_webserver/meta_modeling/_results.py

@@ -110,5 +110,5 @@ def extract_project_results(workbench: dict[str, Any]) -> ExtractedResults:
             values = node["outputs"]
             results[noid], labels[noid] = values, label
 
-    res = ExtractedResults(progress=progress, labels=labels, values=results)  # type: ignore[arg-type]
+    res = ExtractedResults(progress=progress, labels=labels, values=results)
     return res

services/web/server/src/simcore_service_webserver/notifications/_rabbitmq_exclusive_queue_consumers.py

@@ -13,7 +13,7 @@
 )
 from models_library.socketio import SocketMessageDict
 from models_library.users import GroupID
-from pydantic import parse_raw_as
+from pydantic import TypeAdapter, parse_raw_as
 from servicelib.logging_utils import log_catch, log_context
 from servicelib.rabbitmq import RabbitMQClient
 from servicelib.utils import logged_gather
@@ -67,8 +67,10 @@ async def _convert_to_node_update_event(
 async def _progress_message_parser(app: web.Application, data: bytes) -> bool:
     rabbit_message: (
         ProgressRabbitMessageNode | ProgressRabbitMessageProject
-    ) = parse_raw_as(
-        ProgressRabbitMessageNode | ProgressRabbitMessageProject, data  # type: ignore[arg-type] # from pydantic v2 --> https://github.com/pydantic/pydantic/discussions/4950
+    ) = TypeAdapter(
+        ProgressRabbitMessageNode | ProgressRabbitMessageProject
+    ).validate_json(
+        data
     )
     message: SocketMessageDict | None = None
     if isinstance(rabbit_message, ProgressRabbitMessageProject):

services/web/server/src/simcore_service_webserver/payments/_onetime_api.py

@@ -1,6 +1,6 @@
 import logging
 from decimal import Decimal
-from typing import Any, cast
+from typing import Any
 from uuid import uuid4
 
 import arrow
@@ -235,11 +235,8 @@ async def _fake_get_payment_invoice_url(
     assert user_id  # nosec
     assert wallet_id  # nosec
 
-    return cast(
-        HttpUrl,
-        TypeAdapter(HttpUrl).validate_python(
-            f"https://fake-invoice.com/?id={payment_id}"
-        ),
+    return TypeAdapter(HttpUrl).validate_python(
+        f"https://fake-invoice.com/?id={payment_id}",
     )
 
 

services/web/server/src/simcore_service_webserver/products/_db.py

@@ -100,7 +100,7 @@ async def get_product(self, product_name: str) -> Product | None:
                 return Product(
                     **dict(row.items()),
                     is_payment_enabled=payments.enabled,
-                    credits_per_usd=payments.credits_per_usd,  # type: ignore[arg-type]
+                    credits_per_usd=payments.credits_per_usd,
                 )
             return None
 

services/web/server/src/simcore_service_webserver/products/_invitations_handlers.py

@@ -55,13 +55,13 @@ async def generate_invitation(request: web.Request):
     assert generated.product == req_ctx.product_name  # nosec
     assert generated.guest == body.guest  # nosec
 
-    url = URL(generated.invitation_url)
+    url = URL(f"{generated.invitation_url}")
     invitation_link = request.url.with_path(url.path).with_fragment(url.raw_fragment)
 
     invitation = InvitationGenerated(
         product_name=generated.product,
         issuer=generated.issuer,
-        guest=generated.guest,  # type: ignore[arg-type]
+        guest=generated.guest,
         trial_account_days=generated.trial_account_days,
         extra_credits_in_usd=generated.extra_credits_in_usd,
         created=generated.created,

services/web/server/src/simcore_service_webserver/projects/lock.py

@@ -53,7 +53,7 @@ async def lock_project(
             blocking=False,
             token=ProjectLocked(
                 value=True,
-                owner=Owner(user_id=user_id, **user_fullname),  # type: ignore[arg-type]
+                owner=Owner(user_id=user_id, **user_fullname),
                 status=status,
             ).json(),
         ):

services/web/server/src/simcore_service_webserver/projects/projects_api.py

@@ -1418,7 +1418,7 @@ async def _get_project_lock_state(
             )
             return ProjectLocked(
                 value=False,
-                owner=Owner(user_id=list(set_user_ids)[0], **usernames[0]),  # type: ignore[arg-type]
+                owner=Owner(user_id=list(set_user_ids)[0], **usernames[0]),
                 status=ProjectStatus.OPENED,
             )
     # the project is opened in another tab or browser, or by another user, both case resolves to the project being locked, and opened
@@ -1429,7 +1429,7 @@ async def _get_project_lock_state(
     )
     return ProjectLocked(
         value=True,
-        owner=Owner(user_id=list(set_user_ids)[0], **usernames[0]),  # type: ignore[arg-type]
+        owner=Owner(user_id=list(set_user_ids)[0], **usernames[0]),
         status=ProjectStatus.OPENED,
     )
 

services/web/server/src/simcore_service_webserver/resource_usage/_service_runs_handlers.py

@@ -165,7 +165,9 @@ async def list_resource_usage_services(request: web.Request):
         offset=query_params.offset,
         limit=query_params.limit,
         order_by=TypeAdapter(OrderBy).validate_python(query_params.order_by),
-        filters=TypeAdapter(ServiceResourceUsagesFilters | None).validate_python(query_params.filters),  # type: ignore[arg-type] # from pydantic v2 --> https://github.com/pydantic/pydantic/discussions/4950
+        filters=TypeAdapter(ServiceResourceUsagesFilters | None).validate_python(
+            query_params.filters
+        ),
     )
 
     page = Page[dict[str, Any]].model_validate(
@@ -242,7 +244,9 @@ async def export_resource_usage_services(request: web.Request):
         user_id=req_ctx.user_id,
         product_name=req_ctx.product_name,
         wallet_id=query_params.wallet_id,
-        order_by=TypeAdapter(OrderBy | None).validate_python(query_params.order_by),  # type: ignore[arg-type] # from pydantic v2 --> https://github.com/pydantic/pydantic/discussions/4950
-        filters=TypeAdapter(ServiceResourceUsagesFilters | None).validate_python(query_params.filters),  # type: ignore[arg-type] # from pydantic v2 --> https://github.com/pydantic/pydantic/discussions/4950
+        order_by=TypeAdapter(OrderBy | None).validate_python(query_params.order_by),
+        filters=TypeAdapter(ServiceResourceUsagesFilters | None).validate_python(
+            query_params.filters
+        ),
     )
     raise web.HTTPFound(location=f"{download_url}")

services/web/server/src/simcore_service_webserver/studies_dispatcher/_projects.py

@@ -71,7 +71,7 @@ def _create_file_picker(download_link: str, output_label: str | None):
         label="File Picker",
         inputs={},
         inputNodes=[],
-        outputs={output_id: output},  # type: ignore[dict-item]
+        outputs={output_id: output},
         progress=0,
     )
     return node, output_id
@@ -96,12 +96,12 @@ def _create_project(
         uuid=project_id,
         name=name,
         description=description,
-        thumbnail=thumbnail,  # type: ignore[arg-type]
+        thumbnail=thumbnail,
         prjOwner=owner.email,
         accessRights={owner.primary_gid: access_rights},  # type: ignore[dict-item]
         creationDate=DateTimeStr(now_str()),
         lastChangeDate=DateTimeStr(now_str()),
-        workbench=workbench,  # type: ignore[arg-type]
+        workbench=workbench,
         ui=StudyUI(workbench=workbench_ui),  # type: ignore[arg-type]
     )
 
@@ -155,7 +155,7 @@ def _create_project_with_filepicker_and_service(
         version=viewer_info.version,
         label=viewer_info.label,
         inputs={
-            viewer_info.input_port_key: PortLink(  # type: ignore[dict-item]
+            viewer_info.input_port_key: PortLink(
                 nodeUuid=file_picker_id,
                 output=file_picker_output_id,
             )