upload logs in case of failure

Author: sanderegg

.github/workflows/ci-testing-deploy.yml

@@ -1904,19 +1904,23 @@ jobs:
       - name: test
         run: ./ci/github/system-testing/e2e.bash test
       - name: dump docker logs
+        if: ${{ failure() }}
         id: docker_logs_dump
         run: ./ci/github/system-testing/e2e.bash dump_docker_logs
       - name: upload docker logs
+        if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
           name: ${{ github.job }}_docker_logs
           path: ./tests/e2e/test_failures
       - name: upload screenshots
+        if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
           name: ${{ github.job }}_screenshots
           path: tests/e2e/screenshots
       - name: upload e2e logs
+        if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
           name: ${{ github.job }}_logs
@@ -1956,14 +1960,17 @@ jobs:
         run: |
           ./ci/github/system-testing/e2e-playwright.bash test
       - name: dump docker logs
+        if: ${{ failure() }}
         id: docker_logs_dump
         run: ./ci/github/system-testing/e2e-playwright.bash dump_docker_logs
       - name: upload docker logs
+        if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
           name: ${{ github.job }}_docker_logs
           path: ./tests/e2e-playwright/test_failures
       - name: upload tracing if failed
+        if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
           name: ${{ github.job }}_tracing