Skip to content

Commit 89d98e2

Browse files
committed
rm rabbit client
1 parent 80fa7fe commit 89d98e2

File tree

7 files changed

+3
-13
lines changed

7 files changed

+3
-13
lines changed

services/api-server/src/simcore_service_api_server/services_rpc/wb_api_server.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ def _create_licensed_items_get_page(
124124
@dataclass
125125
class WbApiRpcClient(SingletonInAppStateMixin):
126126
app_state_name = "wb_api_rpc_client"
127-
_client: RabbitMQRPCClient
128127
_rpc_client: WebServerRpcClient
129128

130129
@_exception_mapper(rpc_exception_map={})
@@ -668,7 +667,6 @@ def setup(app: FastAPI, rabbitmq_rpc_client: RabbitMQRPCClient):
668667
raise ConfigurationError(tip="Webserver settings are not configured")
669668

670669
wb_api_rpc_client = WbApiRpcClient(
671-
_client=rabbitmq_rpc_client,
672670
_rpc_client=WebServerRpcClient(
673671
rabbitmq_rpc_client, webserver_settings.WEBSERVER_RPC_NAMESPACE
674672
),

services/api-server/tests/unit/api_functions/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ async def mock_wb_api_server_rpc(app: FastAPI, mocker: MockerFixture) -> MockerF
9797
from servicelib.rabbitmq.rpc_interfaces.webserver.v1 import WebServerRpcClient
9898

9999
app.dependency_overrides[get_wb_api_rpc_client] = lambda: WbApiRpcClient(
100-
_client=DummyRpcClient(),
101100
_rpc_client=mocker.MagicMock(spec=WebServerRpcClient),
102101
)
103102
return mocker

services/api-server/tests/unit/api_functions/test_api_routers_functions.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,11 +434,9 @@ def _get_rabbitmq_rpc_client(app: FastAPI) -> RabbitMQRPCClient:
434434
)
435435

436436
async def _get_wb_api_rpc_client(app: FastAPI) -> WbApiRpcClient:
437-
from servicelib.rabbitmq import RabbitMQRPCClient
438437
from servicelib.rabbitmq.rpc_interfaces.webserver.v1 import WebServerRpcClient
439438

440439
return WbApiRpcClient(
441-
_client=mocker.MagicMock(spec=RabbitMQRPCClient),
442440
_rpc_client=mocker.MagicMock(spec=WebServerRpcClient),
443441
)
444442

services/api-server/tests/unit/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,25 +260,25 @@ def mocked_app_dependencies(app: FastAPI, mocker: MockerFixture) -> Iterator[Non
260260
"""
261261
assert app.state.settings.API_SERVER_RABBITMQ is None
262262
from servicelib.rabbitmq import RabbitMQRPCClient
263-
from servicelib.rabbitmq.rpc_interfaces.webserver.v1 import WebServerRpcClient
264263
from simcore_service_api_server.api.dependencies.rabbitmq import (
265264
get_rabbitmq_rpc_client,
266265
)
267266
from simcore_service_api_server.api.dependencies.webserver_rpc import (
268267
get_wb_api_rpc_client,
269268
)
270-
from simcore_service_api_server.core.settings import WebServerSettings
271269

272270
def _get_rabbitmq_rpc_client_override():
273271
return mocker.MagicMock()
274272

275273
async def _get_wb_api_rpc_client_override():
274+
from servicelib.rabbitmq.rpc_interfaces.webserver.v1 import WebServerRpcClient
275+
from simcore_service_api_server.core.settings import WebServerSettings
276+
276277
webserver_settings: WebServerSettings = app.state.settings.API_SERVER_WEBSERVER
277278
assert webserver_settings.WEBSERVER_RPC_NAMESPACE
278279

279280
rabbitmq_rpc_client = mocker.MagicMock(spec=RabbitMQRPCClient)
280281
return WbApiRpcClient(
281-
_client=rabbitmq_rpc_client,
282282
_rpc_client=WebServerRpcClient(
283283
rabbitmq_rpc_client, webserver_settings.WEBSERVER_RPC_NAMESPACE
284284
),

services/api-server/tests/unit/pact_broker/test_pact_checkout_release.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,9 @@
6262

6363
@pytest.fixture
6464
async def mock_wb_api_server_rpc(app: FastAPI, mocker: MockerFixture) -> None:
65-
from servicelib.rabbitmq import RabbitMQRPCClient
6665
from servicelib.rabbitmq.rpc_interfaces.webserver.v1 import WebServerRpcClient
6766

6867
app.dependency_overrides[get_wb_api_rpc_client] = lambda: WbApiRpcClient(
69-
_client=mocker.MagicMock(spec=RabbitMQRPCClient),
7068
_rpc_client=mocker.MagicMock(spec=WebServerRpcClient),
7169
)
7270

services/api-server/tests/unit/pact_broker/test_pact_licensed_items.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,9 @@ class DummyRpcClient:
138138

139139
@pytest.fixture
140140
async def mock_wb_api_server_rpc(app: FastAPI, mocker: MockerFixture) -> None:
141-
from servicelib.rabbitmq import RabbitMQRPCClient
142141
from servicelib.rabbitmq.rpc_interfaces.webserver.v1 import WebServerRpcClient
143142

144143
app.dependency_overrides[get_wb_api_rpc_client] = lambda: WbApiRpcClient(
145-
_client=mocker.MagicMock(spec=RabbitMQRPCClient),
146144
_rpc_client=mocker.MagicMock(spec=WebServerRpcClient),
147145
)
148146

services/api-server/tests/unit/test_licensed_items.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ async def mock_wb_api_server_rcp(app: FastAPI, mocker: MockerFixture) -> MockerF
8080
from servicelib.rabbitmq.rpc_interfaces.webserver.v1 import WebServerRpcClient
8181

8282
app.dependency_overrides[get_wb_api_rpc_client] = lambda: WbApiRpcClient(
83-
_client=mocker.MagicMock(spec=RabbitMQRPCClient),
8483
_rpc_client=mocker.MagicMock(spec=WebServerRpcClient),
8584
)
8685
return mocker

0 commit comments

Comments
 (0)