fix: use user as recipients

Author: giancarloromeo

services/web/server/src/simcore_service_webserver/conversations/_conversation_message_service.py

@@ -17,6 +17,7 @@
 from models_library.users import UserID
 
 from ..projects._groups_repository import list_project_groups
+from ..users._users_service import get_users_in_group
 
 # Import or define SocketMessageDict
 from ..users.api import get_user_primary_group_id
@@ -30,13 +31,20 @@
 _logger = logging.getLogger(__name__)
 
 
-async def _get_recipients(app, project_id):
-    return [
+async def _get_recipients(app, project_id) -> set[UserID]:
+    groups = [
         project_to_group.gid
         for project_to_group in await list_project_groups(app, project_id=project_id)
         if project_to_group.read
     ]
 
+    recipients = set()
+    for group_id in groups:
+        group_users = await get_users_in_group(app, gid=group_id)
+        recipients.update(group_users)
+
+    return recipients
+
 
 async def create_message(
     app: web.Application,

services/web/server/src/simcore_service_webserver/conversations/_socketio.py

@@ -8,9 +8,9 @@
     ConversationMessageGetDB,
     ConversationMessageID,
 )
-from models_library.groups import GroupID
 from models_library.projects import ProjectID
 from models_library.socketio import SocketMessageDict
+from models_library.users import UserID
 from pydantic import BaseModel
 
 from ..socketio.messages import send_message_to_standard_group
@@ -52,7 +52,7 @@ async def _send_message_to_recipients(app, recipients, notification_message):
 async def notify_conversation_message_created(
     app: web.Application,
     *,
-    recipients: list[GroupID],
+    recipients: list[UserID],
     project_id: ProjectID,
     conversation_message: ConversationMessageGetDB,
 ) -> None:
@@ -72,7 +72,7 @@ async def notify_conversation_message_created(
 async def notify_conversation_message_updated(
     app: web.Application,
     *,
-    recipients: list[GroupID],
+    recipients: list[UserID],
     project_id: ProjectID,
     conversation_message: ConversationMessageGetDB,
 ) -> None:
@@ -93,7 +93,7 @@ async def notify_conversation_message_updated(
 async def notify_conversation_message_deleted(
     app: web.Application,
     *,
-    recipients: list[GroupID],
+    recipients: list[UserID],
     project_id: ProjectID,
     conversation_id: ConversationID,
     message_id: ConversationMessageID,