Skip to content

Commit 8c5b95d

Browse files
Removes unused frontend outputs update logic
Cleans up obsolete code related to updating frontend node outputs, streamlining the module and reducing maintenance overhead. This helps avoid confusion and ensures only relevant logic is retained.
1 parent 92cb19f commit 8c5b95d

File tree

1 file changed

+1
-50
lines changed
  • services/web/server/src/simcore_service_webserver/projects

1 file changed

+1
-50
lines changed

services/web/server/src/simcore_service_webserver/projects/nodes_utils.py

Lines changed: 1 addition & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,15 @@
11
import logging
2-
from collections import deque
3-
from collections.abc import Coroutine
42
from typing import Any
53

64
from aiohttp import web
75
from models_library.errors import ErrorDict
86
from models_library.projects import ProjectID
97
from models_library.projects_nodes_io import NodeID
108
from models_library.users import UserID
11-
from servicelib.aiohttp.application_keys import APP_FIRE_AND_FORGET_TASKS_KEY
129
from servicelib.logging_utils import log_decorator
13-
from servicelib.utils import fire_and_forget_task, logged_gather
10+
from servicelib.utils import logged_gather
1411

1512
from . import _projects_service
16-
from .utils import get_frontend_node_outputs_changes
1713

1814
log = logging.getLogger(__name__)
1915

@@ -91,48 +87,3 @@ async def update_node_outputs(
9187
await _projects_service.post_trigger_connected_service_retrieve(
9288
app=app, project=project, updated_node_uuid=f"{node_uuid}", changed_keys=keys
9389
)
94-
95-
96-
async def update_frontend_outputs(
97-
app: web.Application,
98-
user_id: UserID,
99-
project_uuid: ProjectID,
100-
old_project: dict[str, Any],
101-
new_project: dict[str, Any],
102-
) -> None:
103-
old_workbench = old_project["workbench"]
104-
new_workbench = new_project["workbench"]
105-
frontend_nodes_update_tasks: deque[Coroutine] = deque()
106-
107-
for node_key, node in new_workbench.items():
108-
old_node = old_workbench.get(node_key)
109-
if not old_node:
110-
continue
111-
112-
# check if there were any changes in the outputs of
113-
# frontend services
114-
# NOTE: for now only file-picker is handled
115-
outputs_changes: set[str] = get_frontend_node_outputs_changes(
116-
new_node=node, old_node=old_node
117-
)
118-
119-
if len(outputs_changes) > 0:
120-
frontend_nodes_update_tasks.append(
121-
update_node_outputs(
122-
app=app,
123-
user_id=user_id,
124-
project_uuid=project_uuid,
125-
node_uuid=node_key,
126-
outputs=node.get("outputs", {}),
127-
run_hash=None,
128-
node_errors=None,
129-
ui_changed_keys=outputs_changes,
130-
)
131-
)
132-
133-
for task_index, frontend_node_update_task in enumerate(frontend_nodes_update_tasks):
134-
fire_and_forget_task(
135-
frontend_node_update_task,
136-
task_suffix_name=f"frontend_node_update_task_{task_index}",
137-
fire_and_forget_tasks_collection=app[APP_FIRE_AND_FORGET_TASKS_KEY],
138-
)

0 commit comments

Comments
 (0)