cleanup

Author: pcrespov

services/catalog/src/simcore_service_catalog/core/background_tasks.py

@@ -76,7 +76,7 @@ def _by_version(t: tuple[ServiceKey, ServiceVersion]) -> Version:
             (
                 owner_gid,
                 service_access_rights,
-            ) = await access_rights.evaluate_service_ownership_and_rights(
+            ) = await access_rights.evaluate_default_service_ownership_and_rights(
                 app,
                 service=service_metadata,
                 product_name=app.state.default_product_name,

services/catalog/src/simcore_service_catalog/service/access_rights.py

@@ -48,7 +48,7 @@ async def _is_old_service(app: FastAPI, service: ServiceMetaDataPublished) -> bo
     return bool(service_build_data < _LEGACY_SERVICES_DATE)
 
 
-async def evaluate_service_ownership_and_rights(
+async def evaluate_default_service_ownership_and_rights(
     app: FastAPI, *, service: ServiceMetaDataPublished, product_name: ProductName
 ) -> tuple[GroupID | None, list[ServiceAccessRightsDB]]:
     """Evaluates the owner (group_id) and the access rights for a service

services/catalog/tests/unit/with_dbs/test_service_access_rights.py

@@ -15,7 +15,7 @@
 from simcore_service_catalog.models.services_db import ServiceAccessRightsDB
 from simcore_service_catalog.repository.services import ServicesRepository
 from simcore_service_catalog.service.access_rights import (
-    evaluate_service_ownership_and_rights,
+    evaluate_default_service_ownership_and_rights,
     inherit_from_previous_release,
     reduce_access_rights,
 )
@@ -186,8 +186,10 @@ async def test_auto_upgrade_policy(
     services_repo = ServicesRepository(app.state.engine)
 
     # DEFAULT policies
-    owner_gid, service_access_rights = await evaluate_service_ownership_and_rights(
-        app, service=new_service_metadata, product_name=target_product
+    owner_gid, service_access_rights = (
+        await evaluate_default_service_ownership_and_rights(
+            app, service=new_service_metadata, product_name=target_product
+        )
     )
     assert owner_gid == user_gid
     assert len(service_access_rights) == 1