Skip to content

Commit 8da86df

Browse files
committed
futher bugfixes
1 parent f5f72c4 commit 8da86df

File tree

3 files changed

+23
-15
lines changed

3 files changed

+23
-15
lines changed

services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -329,13 +329,17 @@ async def get_function_job_logs_task(
329329
async_job_get = await job_service.start_log_export(
330330
job_id=function_job.project_job_id,
331331
)
332-
_task_id = f"{async_job_get.job_id}"
332+
_task_uuid = f"{async_job_get.job_id}"
333333
return TaskGet(
334-
task_id=_task_id,
334+
task_id=_task_uuid,
335335
task_name=async_job_get.job_name,
336-
status_href=app_router.url_path_for("get_task_status", task_id=_task_id),
337-
abort_href=app_router.url_path_for("cancel_task", task_id=_task_id),
338-
result_href=app_router.url_path_for("get_task_result", task_id=_task_id),
336+
status_href=app_router.url_path_for(
337+
"get_task_status", task_uuid=_task_uuid
338+
),
339+
abort_href=app_router.url_path_for("cancel_task", task_uuid=_task_uuid),
340+
result_href=app_router.url_path_for(
341+
"get_task_result", task_uuid=_task_uuid
342+
),
339343
)
340344

341345
if (
@@ -350,12 +354,16 @@ async def get_function_job_logs_task(
350354
async_job_get = await job_service.start_log_export(
351355
job_id=function_job.solver_job_id,
352356
)
353-
_task_id = f"{async_job_get.job_id}"
357+
_task_uuid = f"{async_job_get.job_id}"
354358
return TaskGet(
355-
task_id=_task_id,
359+
task_id=_task_uuid,
356360
task_name=async_job_get.job_name,
357-
status_href=app_router.url_path_for("get_task_status", task_id=_task_id),
358-
abort_href=app_router.url_path_for("cancel_task", task_id=_task_id),
359-
result_href=app_router.url_path_for("get_task_result", task_id=_task_id),
361+
status_href=app_router.url_path_for(
362+
"get_task_status", task_uuid=_task_uuid
363+
),
364+
abort_href=app_router.url_path_for("cancel_task", task_uuid=_task_uuid),
365+
result_href=app_router.url_path_for(
366+
"get_task_result", task_uuid=_task_uuid
367+
),
360368
)
361369
raise UnsupportedFunctionClassError(function_class=function.function_class)

services/api-server/src/simcore_service_api_server/api/routes/tasks.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ async def list_tasks(
8686
task_id=f"{task.uuid}",
8787
task_name=task.metadata.name,
8888
status_href=app_router.url_path_for(
89-
"get_task_status", task_id=f"{task.uuid}"
89+
"get_task_status", task_uuid=f"{task.uuid}"
9090
),
91-
abort_href=app_router.url_path_for("cancel_task", task_id=f"{task.uuid}"),
91+
abort_href=app_router.url_path_for("cancel_task", task_uuid=f"{task.uuid}"),
9292
result_href=app_router.url_path_for(
93-
"get_task_result", task_id=f"{task.uuid}"
93+
"get_task_result", task_uuid=f"{task.uuid}"
9494
),
9595
)
9696
for task in tasks

services/storage/src/simcore_service_storage/api/_worker_tasks/_simcore_s3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ async def _progress_cb(report: ProgressReport) -> None:
108108

109109
async def export_data_as_download_link(
110110
task: Task,
111-
task_id: TaskKey,
111+
task_key: TaskKey,
112112
*,
113113
user_id: UserID,
114114
paths_to_export: list[PathToExport],
@@ -117,7 +117,7 @@ async def export_data_as_download_link(
117117
AccessRightError: in case user can't access project
118118
"""
119119
s3_object = await export_data(
120-
task=task, task_key=task_id, user_id=user_id, paths_to_export=paths_to_export
120+
task=task, task_key=task_key, user_id=user_id, paths_to_export=paths_to_export
121121
)
122122

123123
dsm = get_dsm_provider(get_app_server(task.app).app).get(

0 commit comments

Comments
 (0)