@GitHK review: annotations

pcrespov · pcrespov · commit 8fcd5b178e97 · 2024-12-05T08:41:54.000+01:00
diff --git a/packages/models-library/src/models_library/service_settings_labels.py b/packages/models-library/src/models_library/service_settings_labels.py
@@ -491,7 +491,7 @@ def _not_allowed_in_both_specs(self):
     model_config = _BaseConfig
 
 
-def _simcore_service_labels_json_schema_extra(schema: JsonDict):
+def _update_json_schema_extra(schema: JsonDict) -> None:
     #
     # NOTE: this will be automatically called with SimcoreServiceLabels.model_json_schema
     #
@@ -601,5 +601,5 @@ class SimcoreServiceLabels(DynamicSidecarServiceLabels):
 
     model_config = _BaseConfig | ConfigDict(
         extra="allow",
-        json_schema_extra=_simcore_service_labels_json_schema_extra,
+        json_schema_extra=_update_json_schema_extra,
     )

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ def _not_allowed_in_both_specs(self):`
`491`	`491`	`model_config = _BaseConfig`
`492`	`492`
`493`	`493`
`494`		`-def _simcore_service_labels_json_schema_extra(schema: JsonDict):`
	`494`	`+def _update_json_schema_extra(schema: JsonDict) -> None:`
`495`	`495`	`#`
`496`	`496`	`# NOTE: this will be automatically called with SimcoreServiceLabels.model_json_schema`
`497`	`497`	`#`
`@@ -601,5 +601,5 @@ class SimcoreServiceLabels(DynamicSidecarServiceLabels):`
`601`	`601`
`602`	`602`	`model_config = _BaseConfig \| ConfigDict(`
`603`	`603`	`extra="allow",`
`604`		`- json_schema_extra=_simcore_service_labels_json_schema_extra,`
	`604`	`+ json_schema_extra=_update_json_schema_extra,`
`605`	`605`	`)`