@odeimaiz review: wrong field

Author: pcrespov

services/web/server/src/simcore_service_webserver/folders/_models.py

@@ -41,8 +41,11 @@ class FolderFilters(Filters):
 
 
 _FolderOrderQueryParams: type[RequestParameters] = create_ordering_query_model_classes(
-    ordering_fields={"modified", "name", "description"},
-    default=OrderBy(field=IDStr("modified"), direction=OrderDirection.DESC),
+    ordering_fields={
+        "modified_at",
+        "name",
+    },
+    default=OrderBy(field=IDStr("modified_at"), direction=OrderDirection.DESC),
 )
 
 
@@ -70,6 +73,13 @@ class Config:
         "workspace_id", allow_reuse=True, pre=True
     )(null_or_none_str_to_none_validator)
 
+    @validator("order_by", always=True)
+    @classmethod
+    def _post_rename_order_by_field_as_db_column(cls, v):
+        if v.field == "modified_at":  # API field
+            v.field = "modified"  # DB column
+        return v
+
 
 class FolderSearchQueryParams(
     PageQueryParameters, _FolderOrderQueryParams, FiltersQueryParameters[FolderFilters]  # type: ignore[misc, valid-type]

services/web/server/src/simcore_service_webserver/resource_usage/_service_runs_handlers.py

@@ -93,9 +93,9 @@ class ServicesResourceUsagesReportQueryParams(
 
     @validator("order_by", always=True)
     @classmethod
-    def _post_rename_order_by_field(cls, v):
-        if v.field == "credit_cost":
-            v.field = "osparc_credits"
+    def _post_rename_order_by_field_as_db_column(cls, v):
+        if v.field == "credit_cost":  # API field
+            v.field = "osparc_credits"  # DB column
         return v
 
     class Config:

services/web/server/src/simcore_service_webserver/workspaces/_workspaces_handlers.py

@@ -79,7 +79,6 @@ class WorkspacesPathParams(StrictRequestParameters):
     ordering_fields={
         "modified_at",
         "name",
-        "description",
     },
     default=OrderBy(field=IDStr("modified_at"), direction=OrderDirection.DESC),
 )
@@ -89,13 +88,13 @@ class WorkspacesListQueryParams(
     PageQueryParameters,
     WorkspacesListOrderQueryParams,  # type: ignore[misc, valid-type]
 ):
-    @validator("order_by", check_fields=False, always=True)
+    @validator("order_by", always=True)
     @classmethod
-    def _post_rename_order_by_field(cls, v):
+    def _post_rename_order_by_field_as_db_column(cls, v):
         # NOTE: PC->MD this is very error-prone (e.g. w/ defaults).
         # Rather create a map to a db interface
-        if v.field == "modified_at":
-            v.field = "modified"
+        if v.field == "modified_at":  # API field
+            v.field = "modified"  # DB column
         return v