Skip to content

Commit 913ff92

Browse files
authored
🔒️ Make Redis Client support TLS (#6342)
1 parent 4e4a70c commit 913ff92

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

.env-devel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ RABBIT_USER=admin
160160
REDIS_HOST=redis
161161
REDIS_PORT=6379
162162
REDIS_PASSWORD=adminadmin
163+
REDIS_SECURE=false
163164

164165
REGISTRY_AUTH=True
165166
REGISTRY_PW=adminadminadmin

packages/settings-library/src/settings_library/redis.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class RedisDatabase(int, Enum):
2121

2222
class RedisSettings(BaseCustomSettings):
2323
# host
24+
REDIS_SECURE: bool = False
2425
REDIS_HOST: str = "redis"
2526
REDIS_PORT: PortInt = parse_obj_as(PortInt, 6789)
2627

@@ -30,7 +31,7 @@ class RedisSettings(BaseCustomSettings):
3031

3132
def build_redis_dsn(self, db_index: RedisDatabase):
3233
return RedisDsn.build(
33-
scheme="redis",
34+
scheme="rediss" if self.REDIS_SECURE else "redis",
3435
user=self.REDIS_USER or None,
3536
password=(
3637
self.REDIS_PASSWORD.get_secret_value() if self.REDIS_PASSWORD else None

services/docker-compose.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ services:
116116
REDIS_HOST: ${REDIS_HOST}
117117
REDIS_PASSWORD: ${REDIS_PASSWORD}
118118
REDIS_PORT: ${REDIS_PORT}
119+
REDIS_SECURE: ${REDIS_SECURE}
119120
REGISTRY_USER: ${REGISTRY_USER}
120121
REGISTRY_PW: ${REGISTRY_PW}
121122
REGISTRY_URL: ${REGISTRY_URL}
@@ -204,6 +205,7 @@ services:
204205
RABBIT_USER: ${RABBIT_USER}
205206
REDIS_HOST: ${REDIS_HOST}
206207
REDIS_PORT: ${REDIS_PORT}
208+
REDIS_SECURE: ${REDIS_SECURE}
207209
REDIS_PASSWORD: ${REDIS_PASSWORD}
208210
SWARM_STACK_NAME: ${SWARM_STACK_NAME}
209211
CLUSTERS_KEEPER_WORKERS_EC2_INSTANCES: ${CLUSTERS_KEEPER_WORKERS_EC2_INSTANCES}
@@ -331,6 +333,7 @@ services:
331333

332334
REDIS_HOST: ${REDIS_HOST}
333335
REDIS_PORT: ${REDIS_PORT}
336+
REDIS_SECURE: ${REDIS_SECURE}
334337
REDIS_PASSWORD: ${REDIS_PASSWORD}
335338

336339
REGISTRY_AUTH: ${REGISTRY_AUTH}
@@ -475,6 +478,7 @@ services:
475478
RABBIT_USER: ${RABBIT_USER}
476479
REDIS_HOST: ${REDIS_HOST}
477480
REDIS_PORT: ${REDIS_PORT}
481+
REDIS_SECURE: ${REDIS_SECURE}
478482
REDIS_PASSWORD: ${REDIS_PASSWORD}
479483
RESOURCE_USAGE_TRACKER_LOGLEVEL: ${RESOURCE_USAGE_TRACKER_LOGLEVEL}
480484
RESOURCE_USAGE_TRACKER_MISSED_HEARTBEAT_CHECK_ENABLED: ${RESOURCE_USAGE_TRACKER_MISSED_HEARTBEAT_CHECK_ENABLED}
@@ -498,6 +502,7 @@ services:
498502
RABBIT_USER: ${RABBIT_USER}
499503
REDIS_HOST: ${REDIS_HOST}
500504
REDIS_PORT: ${REDIS_PORT}
505+
REDIS_SECURE: ${REDIS_SECURE}
501506
REDIS_PASSWORD: ${REDIS_PASSWORD}
502507
DIRECTOR_V2_HOST: ${DIRECTOR_V2_HOST}
503508
DIRECTOR_V2_PORT: ${DIRECTOR_V2_PORT}
@@ -659,6 +664,7 @@ services:
659664
# WEBSERVER_REDIS
660665
REDIS_HOST: ${REDIS_HOST}
661666
REDIS_PORT: ${REDIS_PORT}
667+
REDIS_SECURE: ${REDIS_SECURE}
662668
REDIS_PASSWORD: ${REDIS_PASSWORD}
663669

664670
# WEBSERVER_REST
@@ -846,6 +852,7 @@ services:
846852
# WEBSERVER_REDIS
847853
REDIS_HOST: ${REDIS_HOST}
848854
REDIS_PORT: ${REDIS_PORT}
855+
REDIS_SECURE: ${REDIS_SECURE}
849856
REDIS_PASSWORD: ${REDIS_PASSWORD}
850857

851858
RESOURCE_MANAGER_RESOURCE_TTL_S: ${RESOURCE_MANAGER_RESOURCE_TTL_S}
@@ -894,6 +901,7 @@ services:
894901

895902
REDIS_HOST: ${REDIS_HOST}
896903
REDIS_PORT: ${REDIS_PORT}
904+
REDIS_SECURE: ${REDIS_SECURE}
897905
REDIS_PASSWORD: ${REDIS_PASSWORD}
898906

899907
SWARM_STACK_NAME: ${SWARM_STACK_NAME}
@@ -1032,6 +1040,7 @@ services:
10321040
POSTGRES_USER: ${POSTGRES_USER}
10331041
REDIS_HOST: ${REDIS_HOST}
10341042
REDIS_PORT: ${REDIS_PORT}
1043+
REDIS_SECURE: ${REDIS_SECURE}
10351044
REDIS_PASSWORD: ${REDIS_PASSWORD}
10361045
S3_ACCESS_KEY: ${S3_ACCESS_KEY}
10371046
S3_BUCKET_NAME: ${S3_BUCKET_NAME}

0 commit comments

Comments
 (0)