mionr

Author: pcrespov

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/notifications/_notifications.py

@@ -17,7 +17,7 @@ async def send_notification(
 ) -> None:
     await rabbitmq_rpc_client.request(
         NOTIFICATIONS_RPC_NAMESPACE,
-        TypeAdapter(RPCMethodName).validate_python("send_notification"),
+        TypeAdapter(RPCMethodName).validate_python(send_notification.__name__),
         timeout_s=_DEFAULT_TIMEOUT_S,
         notification=notification,
     )

services/notifications/src/simcore_service_notifications/core/events.py

@@ -47,6 +47,7 @@ def create_app_lifespan(
     app_lifespan.add(_settings_lifespan)
 
     # - postgres
+    # NOTE: for now we will remove
     app_lifespan.add(postgres_database_lifespan)
     app_lifespan.add(postgres_lifespan)
 

services/notifications/src/simcore_service_notifications/modules/celery/_email_tasks.py

@@ -26,6 +26,11 @@ async def send_email_notification(
     notification: Notification,
 ) -> None:
     _ = task, task_id
+
+    #
+    # NOTE: task can be used to provide progress
+    #
+
     assert isinstance(notification.channel, EmailChannel)  # nosec
 
     _logger.info("Sending email notification to %s", notification.channel.to_addr)