Skip to content

Commit 91f3d78

Browse files
Merge branch 'master' into fix-e2e-test-tip-2
2 parents ecca733 + e2aeff5 commit 91f3d78

File tree

51 files changed

+2697
-2277
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+2697
-2277
lines changed

packages/models-library/src/models_library/api_schemas_directorv2/services.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@ class ServiceExtras(BaseModel):
6767
json_schema_extra={
6868
"examples": [
6969
{"node_requirements": node_example}
70-
for node_example in NodeRequirements.model_config["json_schema_extra"][
71-
"examples"
72-
] # type: ignore[index,union-attr]
70+
for node_example in NodeRequirements.model_json_schema()["examples"]
7371
]
7472
+ [
7573
{
@@ -80,9 +78,7 @@ class ServiceExtras(BaseModel):
8078
"vcs_url": "[email protected]:ITISFoundation/osparc-simcore.git",
8179
},
8280
}
83-
for node_example in NodeRequirements.model_config["json_schema_extra"][
84-
"examples"
85-
] # type: ignore[index,dict-item, union-attr]
81+
for node_example in NodeRequirements.model_json_schema()["examples"]
8682
]
8783
+ [
8884
{
@@ -94,9 +90,7 @@ class ServiceExtras(BaseModel):
9490
},
9591
"container_spec": {"Command": ["run", "subcommand"]},
9692
}
97-
for node_example in NodeRequirements.model_config["json_schema_extra"][
98-
"examples"
99-
] # type: ignore[index,union-attr]
93+
for node_example in NodeRequirements.model_json_schema()["examples"]
10094
]
10195
}
10296
)

services/api-server/src/simcore_service_api_server/services_http/webserver.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# pylint: disable=too-many-public-methods
22

3+
import json
34
import logging
45
import urllib.parse
56
from collections.abc import Mapping
@@ -185,14 +186,16 @@ async def _page_projects(
185186
limit: int,
186187
offset: int,
187188
show_hidden: bool,
188-
search: str | None = None,
189+
search_by_project_name: str | None = None,
189190
) -> Page[ProjectGet]:
190191
assert 1 <= limit <= MAXIMUM_NUMBER_OF_ITEMS_PER_PAGE # nosec
191192
assert offset >= 0 # nosec
192193

193194
optional: dict[str, Any] = {}
194-
if search is not None:
195-
optional["search"] = search
195+
if search_by_project_name is not None:
196+
filters_dict = {"search_by_project_name": search_by_project_name}
197+
filters_json = json.dumps(filters_dict)
198+
optional["filters"] = filters_json
196199

197200
with service_exception_handler(
198201
service_name="Webserver",
@@ -353,9 +356,7 @@ async def get_projects_w_solver_page(
353356
limit=limit,
354357
offset=offset,
355358
show_hidden=True,
356-
# WARNING: better way to match jobs with projects (Next PR if this works fine!)
357-
# WARNING: search text has a limit that I needed to increase for the example!
358-
search=solver_name,
359+
search_by_project_name=solver_name,
359360
)
360361

361362
async def get_projects_page(self, *, limit: int, offset: int):

0 commit comments

Comments
 (0)