Skip to content

Commit 93e500a

Browse files
fix tests
1 parent 878cc43 commit 93e500a

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
"""Add base_url column to products
22
3-
Revision ID: 972981ff823a
3+
Revision ID: 4cfd5b1582cc
44
Revises: 0d52976dc616
5-
Create Date: 2025-05-06 11:28:58.402681+00:00
5+
Create Date: 2025-05-06 14:35:52.213784+00:00
66
77
"""
88

99
import sqlalchemy as sa
1010
from alembic import op
1111

1212
# revision identifiers, used by Alembic.
13-
revision = "972981ff823a"
13+
revision = "4cfd5b1582cc"
1414
down_revision = "0d52976dc616"
1515
branch_labels = None
1616
depends_on = None
@@ -21,7 +21,7 @@ def upgrade():
2121
op.add_column(
2222
"products",
2323
sa.Column(
24-
"base_url", sa.String(), server_default="https://osparc.io", nullable=True
24+
"base_url", sa.String(), server_default="https://osparc.io", nullable=False
2525
),
2626
)
2727
# ### end Alembic commands ###

packages/postgres-database/src/simcore_postgres_database/models/products.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ class ProductLoginSettingsDict(TypedDict, total=False):
157157
sa.Column(
158158
"base_url",
159159
sa.String,
160+
nullable=False,
160161
server_default="https://osparc.io",
161162
doc="Base URL of the product.",
162163
),

services/web/server/src/simcore_service_webserver/products/_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from .models import Product
2424

2525

26-
def _make_api_server_base_url(base_url: str):
26+
def _make_api_server_base_url(base_url: str) -> str:
2727
parsed = urlparse(base_url)
2828
hostname = parsed.hostname or ""
2929

0 commit comments

Comments
 (0)