fix get function job outputs and test

Author: bisgaard-itis

services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py

@@ -317,7 +317,11 @@ async def function_job_outputs(
         function.function_class == FunctionClass.PROJECT
         and function_job.function_class == FunctionClass.PROJECT
     ):
-        assert function_job.project_job_id is not None  # nosec
+        if function_job.project_job_id is None:
+            raise HTTPException(
+                status_code=status.HTTP_404_NOT_FOUND,
+                detail="Function job outputs not found",
+            )
         new_outputs = dict(
             (
                 await studies_jobs.get_study_job_outputs(
@@ -333,7 +337,11 @@ async def function_job_outputs(
         function.function_class == FunctionClass.SOLVER
         and function_job.function_class == FunctionClass.SOLVER
     ):
-        assert function_job.solver_job_id is not None  # nosec
+        if function_job.solver_job_id is None:
+            raise HTTPException(
+                status_code=status.HTTP_404_NOT_FOUND,
+                detail="Function job outputs not found",
+            )
         new_outputs = dict(
             (
                 await solvers_jobs_read.get_job_outputs(

services/api-server/tests/unit/api_functions/test_api_routers_function_jobs.py

@@ -310,19 +310,39 @@ async def _get_task_status(
             )
 
 
-@pytest.mark.parametrize("job_outputs", [{"X+Y": 42, "X-Y": 10}])
+@pytest.mark.parametrize(
+    "job_outputs, project_job_id",
+    [
+        (None, None),
+        ({"X+Y": 42, "X-Y": 10}, ProjectID(_faker.uuid4())),
+    ],
+)
 async def test_get_function_job_outputs(
     client: AsyncClient,
     mock_handler_in_functions_rpc_interface: Callable[[str, Any], None],
     mock_registered_project_function_job: RegisteredProjectFunctionJob,
     mock_registered_project_function: RegisteredProjectFunction,
     mocked_webserver_rpc_api: dict[str, MockType],
     auth: httpx.BasicAuth,
-    job_outputs: dict[str, Any],
+    job_outputs: dict[str, Any] | None,
+    project_job_id: ProjectID | None,
 ) -> None:
 
+    _expected_return_status = (
+        status.HTTP_404_NOT_FOUND
+        if project_job_id is None and job_outputs is None
+        else status.HTTP_200_OK
+    )
+
     mock_handler_in_functions_rpc_interface(
-        "get_function_job", mock_registered_project_function_job
+        "get_function_job",
+        mock_registered_project_function_job.model_copy(
+            update={
+                "user_id": ANY,
+                "project_job_id": project_job_id,
+                "job_creation_task_id": None,
+            }
+        ),
     )
     mock_handler_in_functions_rpc_interface(
         "get_function", mock_registered_project_function
@@ -333,6 +353,7 @@ async def test_get_function_job_outputs(
         f"{API_VTAG}/function_jobs/{mock_registered_project_function_job.uid}/outputs",
         auth=auth,
     )
-    assert response.status_code == status.HTTP_200_OK
-    data = response.json()
-    assert data == job_outputs
+    assert response.status_code == _expected_return_status
+    if response.status_code == status.HTTP_200_OK:
+        data = response.json()
+        assert data == job_outputs