Skip to content

Commit 94c8701

Browse files
committed
added note
1 parent 035420d commit 94c8701

File tree

1 file changed

+2
-2
lines changed
  • services/director-v2/src/simcore_service_director_v2/modules/db/repositories

1 file changed

+2
-2
lines changed

services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_runs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,12 @@ def _handle_foreign_key_violation(
9595

9696
def _resolve_grouped_state(states: list[RunningState]) -> RunningState:
9797
# If any state is not a final state, return STARTED
98+
9899
final_states = {
99100
RunningState.FAILED,
100101
RunningState.ABORTED,
101102
RunningState.SUCCESS,
102-
RunningState.UNKNOWN,
103+
RunningState.UNKNOWN, # NOTE: this is NOT a final state, but happens when tasks are missing
103104
}
104105
if any(state not in final_states for state in states):
105106
return RunningState.STARTED
@@ -399,7 +400,6 @@ async def list_all_collection_run_ids_for_user_currently_running_computations(
399400
product_name: str,
400401
user_id: UserID,
401402
) -> list[CollectionRunID]:
402-
403403
list_query = (
404404
sa.select(
405405
comp_runs.c.collection_run_id,

0 commit comments

Comments
 (0)