renaming

Author: Andrei Neagu

packages/common-library/src/common_library/pydantic_validators.py

@@ -15,6 +15,6 @@ def _try_convert_str_to_float_or_return(
     return v
 
 
-def validate_timedelta_in_legacy_mode(field: str):
+def timedelta_try_convert_str_to_float(field: str):
     """Transforms a float/int number into a valid datetime as it used to work in the past"""
     return field_validator(field, mode="before")(_try_convert_str_to_float_or_return)

packages/common-library/tests/test_pydantic_settings_validators.py

@@ -1,7 +1,7 @@
 from datetime import timedelta
 
 import pytest
-from common_library.pydantic_validators import validate_timedelta_in_legacy_mode
+from common_library.pydantic_validators import timedelta_try_convert_str_to_float
 from faker import Faker
 from pydantic import Field
 from pydantic_settings import BaseSettings, SettingsConfigDict
@@ -15,7 +15,7 @@ class Settings(BaseSettings):
         APP_NAME: str
         REQUEST_TIMEOUT: timedelta = Field(default=timedelta(seconds=40))
 
-        _legacy_parsing_request_timeout = validate_timedelta_in_legacy_mode(
+        _try_convert_request_timeout = timedelta_try_convert_str_to_float(
             "REQUEST_TIMEOUT"
         )
 

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py

@@ -5,7 +5,7 @@
 from typing import cast
 
 from common_library.pydantic_type_adapters import ByteSizeAdapter
-from common_library.pydantic_validators import validate_timedelta_in_legacy_mode
+from common_library.pydantic_validators import timedelta_try_convert_str_to_float
 from models_library.basic_types import BootModeEnum, PortInt
 from models_library.callbacks_mapping import CallbacksMapping
 from models_library.products import ProductName
@@ -33,8 +33,8 @@ class ResourceTrackingSettings(BaseCustomSettings):
         description="each time the status of the service is propagated",
     )
 
-    _legacy_parsing_dynamic_scheduler_stop_service_timeout = (
-        validate_timedelta_in_legacy_mode("RESOURCE_TRACKING_HEARTBEAT_INTERVAL")
+    _try_convert_resource_tracking_heartbeat_interval = (
+        timedelta_try_convert_str_to_float("RESOURCE_TRACKING_HEARTBEAT_INTERVAL")
     )
 
 
@@ -201,8 +201,8 @@ def convert_str_to_run_id_object(cls, v):
     def _check_log_level(cls, value):
         return cls.validate_log_level(value)
 
-    _legacy_parsing_dynamic_telemetry_disk_usage_monitor_interval = (
-        validate_timedelta_in_legacy_mode(
+    _try_convert_dynamic_sidecar_telemetry_disk_usage_monitor_interval = (
+        timedelta_try_convert_str_to_float(
             "DYNAMIC_SIDECAR_TELEMETRY_DISK_USAGE_MONITOR_INTERVAL"
         )
     )