Skip to content

Commit 9736475

Browse files
committed
cleanup
1 parent 198855d commit 9736475

File tree

2 files changed

+0
-46
lines changed

2 files changed

+0
-46
lines changed

services/dask-sidecar/README.md

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -13,42 +13,3 @@ source .venv/bin/activate
1313
cd services/api-service
1414
make install-dev
1515
```
16-
17-
## Deploy on a specific cluster
18-
19-
1. define label on docker engine
20-
21-
```bash
22-
sudo nano /etc/docker/daemon.json
23-
```
24-
25-
```json
26-
{
27-
"labels":["cluster_id=MYCLUSTERUNIQUEIDENTIFIER"]
28-
}
29-
```
30-
31-
2. restart the docker engine
32-
33-
```bash
34-
sudo service docker restart
35-
```
36-
37-
3. verify
38-
39-
```bash
40-
docker info --format "{{.Labels}}"
41-
```
42-
43-
44-
## Dev notes
45-
46-
### 2021.08.24
47-
48-
- sidecar sets up its own available resources on start
49-
- sidecar checks local docker engine labels to get its cluster_id
50-
51-
### 2021.06.10
52-
53-
- installed from dynamic-sidecar in current repo, but could have opted for taking sidecar image as a base. The latter would complicate in-host development though, so we start commando here.
54-
- can be started as scheduler or worker. TODO: scheduler does not need to mount anything

services/director-v2/tests/unit/conftest.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
import json
55
import logging
6-
import random
76
import urllib.parse
87
from collections.abc import AsyncIterable, Iterable, Iterator, Mapping
98
from typing import Any
@@ -20,7 +19,6 @@
2019
)
2120
from models_library.basic_types import PortInt
2221
from models_library.callbacks_mapping import CallbacksMapping
23-
from models_library.clusters import ClusterID
2422
from models_library.generated_models.docker_rest_api import (
2523
ServiceSpec as DockerServiceSpec,
2624
)
@@ -159,11 +157,6 @@ def scheduler_data(
159157
}[request.param]
160158

161159

162-
@pytest.fixture
163-
def cluster_id() -> ClusterID:
164-
return random.randint(0, 10)
165-
166-
167160
@pytest.fixture(params=list(FileLinkType))
168161
def tasks_file_link_type(request) -> FileLinkType:
169162
"""parametrized fixture on all FileLinkType enum variants"""

0 commit comments

Comments
 (0)