make pylint happy

Author: bisgaard-itis

services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py

@@ -258,7 +258,7 @@ async def function_job_status(
         raise UnsupportedFunctionFunctionJobClassCombinationError(
             function_class=function.function_class,
             function_job_class=function_job.function_class,
-        )
+        ) from exc
 
 
 async def get_function_from_functionjobid(

services/api-server/src/simcore_service_api_server/api/routes/functions_routes.py

@@ -27,7 +27,7 @@
 
 from ..._service_function_jobs import FunctionJobService
 from ..._service_functions import FunctionService
-from ...celery.worker_tasks.functions_tasks import map as map_task
+from ...celery.worker_tasks.functions_tasks import function_map as map_task
 from ...celery.worker_tasks.functions_tasks import run_function as run_function_task
 from ...exceptions.function_errors import FunctionJobCacheNotFoundError
 from ...models.domain.functions import PreRegisteredFunctionJobData

services/api-server/src/simcore_service_api_server/celery/worker_tasks/functions_tasks.py

@@ -119,7 +119,7 @@ async def run_function(
     )
 
 
-async def map(
+async def function_map(
     task: Task,
     task_id: TaskID,
     *,

services/api-server/src/simcore_service_api_server/celery/worker_tasks/tasks.py

@@ -18,7 +18,7 @@
 from ...models.api_resources import JobLinks
 from ...models.domain.functions import PreRegisteredFunctionJobData
 from ...models.schemas.jobs import JobInputs, JobPricingSpecification
-from .functions_tasks import map, run_function
+from .functions_tasks import function_map, run_function
 
 _logger = logging.getLogger(__name__)
 
@@ -43,4 +43,4 @@ def setup_worker_tasks(app: Celery) -> None:
 
     with log_context(_logger, logging.INFO, msg="worker task registration"):
         register_task(app, run_function)
-        register_task(app, map)
+        register_task(app, function_map)

services/api-server/tests/unit/api_functions/celery/test_functions.py

@@ -440,7 +440,7 @@ async def test_map_function_parent_info(
     with_api_server_celery_worker: TestWorkController,
     client: AsyncClient,
     mock_handler_in_functions_rpc_interface: Callable[
-        [str, Any, Exception | None, Callable | None], None
+        [str, Any, Exception | None, Callable | None], MockType
     ],
     mock_registered_project_function: RegisteredProjectFunction,
     mock_registered_project_function_job: RegisteredFunctionJob,
@@ -550,7 +550,7 @@ def _default_side_effect(
     assert response.status_code == expected_status_code
 
     if expected_status_code == status.HTTP_200_OK:
-        job_collection = FunctionJobCollection.model_validate(response.json())
+        FunctionJobCollection.model_validate(response.json())
         task_id = patch_mock.call_args.kwargs[
             "registered_function_job_patch"
         ].job_creation_task_id

services/api-server/tests/unit/api_functions/conftest.py

@@ -260,7 +260,7 @@ def mock_registered_function_job_collection(
 @pytest.fixture()
 def mock_handler_in_functions_rpc_interface(
     mock_wb_api_server_rpc: MockerFixture,
-) -> Callable[[str, Any, Exception | None, Callable | None], None]:
+) -> Callable[[str, Any, Exception | None, Callable | None], MockType]:
     def _mock(
         handler_name: str = "",
         return_value: Any = None,

services/api-server/tests/unit/api_functions/test_api_routers_function_jobs.py

@@ -1,4 +1,6 @@
 # pylint: disable=unused-argument
+# pylint: disable=too-many-arguments
+# pylint: disable=too-many-positional-arguments
 
 import random
 import uuid
@@ -9,7 +11,6 @@
 
 import httpx
 import pytest
-import simcore_service_api_server.api.routes.function_jobs_routes as function_jobs_routes
 from celery_library.task_manager import CeleryTaskManager
 from faker import Faker
 from fastapi import FastAPI, status
@@ -32,6 +33,7 @@
 from pytest_mock import MockerFixture, MockType
 from servicelib.celery.models import TaskFilter, TaskState, TaskStatus, TaskUUID
 from simcore_service_api_server._meta import API_VTAG
+from simcore_service_api_server.api.routes import function_jobs_routes
 from simcore_service_api_server.api.routes.function_jobs_routes import (
     _JOB_CREATION_TASK_STATUS_PREFIX,
 )
@@ -201,10 +203,10 @@ def mocked_list_function_jobs(offset: int, limit: int):
         (
             ProjectID(_faker.uuid4()),
             TaskID(_faker.uuid4()),
-            random.choice([state for state in TaskState]),
+            random.choice(list(TaskState)),
         ),
-        (None, None, random.choice([state for state in TaskState])),
-        (None, TaskID(_faker.uuid4()), random.choice([state for state in TaskState])),
+        (None, None, random.choice(list(TaskState))),
+        (None, TaskID(_faker.uuid4()), random.choice(list(TaskState))),
     ],
 )
 async def test_get_function_job_status(