Skip to content

Commit 97cb753

Browse files
committed
pass application name
1 parent a08ada5 commit 97cb753

File tree

6 files changed

+25
-16
lines changed

6 files changed

+25
-16
lines changed

packages/simcore-sdk/tests/conftest.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
import pytest
1212
import simcore_sdk
13+
from faker import Faker
1314
from helpers.utils_port_v2 import CONSTANT_UUID
1415
from pytest_mock.plugin import MockerFixture
1516
from pytest_simcore.helpers.postgres_tools import PostgresTestConfig
@@ -85,3 +86,8 @@ def constant_uuid4(mocker: MockerFixture) -> None:
8586
"simcore_sdk.node_ports_common.data_items_utils.uuid4",
8687
return_value=CONSTANT_UUID,
8788
)
89+
90+
91+
@pytest.fixture
92+
def mock_app_name(faker: Faker) -> str:
93+
return faker.pystr()

packages/simcore-sdk/tests/integration/test_node_ports_common_dbmanager.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ async def test_db_manager_read_config(
2121
node_uuid: str,
2222
node_ports_config: None,
2323
default_configuration: dict,
24+
mock_app_name: str,
2425
):
25-
db_manager = DBManager()
26+
db_manager = DBManager(application_name=mock_app_name)
2627
ports_configuration_str = await db_manager.get_ports_configuration_from_node_uuid(
2728
project_id, node_uuid
2829
)
@@ -37,13 +38,14 @@ async def test_db_manager_write_config(
3738
node_ports_config: None,
3839
create_special_configuration: Callable[..., Awaitable[tuple[dict, str, str]]],
3940
default_configuration_file: Path,
41+
mock_app_name: str,
4042
):
4143
# create an empty config
4244
await create_special_configuration()
4345
# read the default config
4446
json_configuration = default_configuration_file.read_text()
4547
# write the default config to the database
46-
db_manager = DBManager()
48+
db_manager = DBManager(application_name=mock_app_name)
4749
await db_manager.write_ports_configuration(
4850
json_configuration, project_id, node_uuid
4951
)

packages/simcore-sdk/tests/unit/conftest.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# pylint:disable=redefined-outer-name
44

55
import json
6-
from collections.abc import AsyncIterator, Callable
6+
from collections.abc import Callable
77
from random import randint
88
from typing import Any
99
from uuid import uuid4
@@ -32,7 +32,8 @@ async def mock_db_manager(
3232
monkeypatch,
3333
project_id: str,
3434
node_uuid: str,
35-
) -> AsyncIterator[Callable]:
35+
mock_app_name: str,
36+
) -> Callable[[dict[str, Any]], DBManager]:
3637
def _mock_db_manager(port_cfg: dict[str, Any]) -> DBManager:
3738
async def mock_get_ports_configuration_from_node_uuid(*args, **kwargs) -> str:
3839
return json.dumps(port_cfg)
@@ -55,7 +56,6 @@ async def mock_write_ports_configuration(
5556
mock_write_ports_configuration,
5657
)
5758

58-
db_manager = DBManager()
59-
return db_manager
59+
return DBManager(application_name=mock_app_name)
6060

6161
return _mock_db_manager

services/api-server/src/simcore_service_api_server/services_http/solver_job_outputs.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
import logging
22
from typing import Any, TypeAlias
33

4-
from models_library.projects import ProjectID, ProjectIDStr
5-
from models_library.projects_nodes_io import BaseFileLink, NodeID, NodeIDStr
4+
from models_library.projects import ProjectID
5+
from models_library.projects_nodes_io import BaseFileLink, NodeID
66
from pydantic import StrictBool, StrictFloat, StrictInt, TypeAdapter
77
from simcore_sdk import node_ports_v2
88
from simcore_sdk.node_ports_v2 import DBManager, Nodeports
99
from sqlalchemy.ext.asyncio import AsyncEngine
1010

11+
from .._meta import APP_NAME
1112
from ..exceptions.backend_errors import SolverOutputNotFoundError
1213

1314
log = logging.getLogger(__name__)
@@ -26,13 +27,13 @@ async def get_solver_output_results(
2627
"""
2728

2829
# get the DB engine
29-
db_manager = DBManager(db_engine=db_engine)
30+
db_manager = DBManager(db_engine=db_engine, application_name=APP_NAME)
3031

3132
try:
3233
solver: Nodeports = await node_ports_v2.ports(
3334
user_id=user_id,
34-
project_id=ProjectIDStr(f"{project_uuid}"),
35-
node_uuid=NodeIDStr(f"{node_uuid}"),
35+
project_id=f"{project_uuid}",
36+
node_uuid=f"{node_uuid}",
3637
db_manager=db_manager,
3738
)
3839
solver_output_results: dict[str, Any] = {}

services/director-v2/src/simcore_service_director_v2/utils/dask.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from models_library.api_schemas_directorv2.services import NodeRequirements
2323
from models_library.docker import DockerLabelKey, StandardSimcoreDockerLabels
2424
from models_library.errors import ErrorDict
25-
from models_library.projects import ProjectID, ProjectIDStr
25+
from models_library.projects import ProjectID
2626
from models_library.projects_nodes_io import NodeID, NodeIDStr
2727
from models_library.services import ServiceKey, ServiceVersion
2828
from models_library.services_types import ServiceRunID
@@ -92,7 +92,7 @@ async def create_node_ports(
9292
db_manager = node_ports_v2.DBManager(db_engine, application_name=APP_NAME)
9393
return await node_ports_v2.ports(
9494
user_id=user_id,
95-
project_id=ProjectIDStr(f"{project_id}"),
95+
project_id=f"{project_id}",
9696
node_uuid=TypeAdapter(NodeIDStr).validate_python(f"{node_id}"),
9797
db_manager=db_manager,
9898
)

services/director-v2/tests/integration/02/test_dynamic_sidecar_nodeports_integration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
NodesDict,
3535
ProjectAtDB,
3636
ProjectID,
37-
ProjectIDStr,
3837
)
3938
from models_library.projects_networks import (
4039
PROJECT_NETWORK_PREFIX,
@@ -70,6 +69,7 @@
7069
from simcore_sdk.node_data import data_manager
7170
from simcore_sdk.node_ports_common.file_io_utils import LogRedirectCB
7271
from simcore_sdk.node_ports_v2 import DBManager, Nodeports, Port
72+
from simcore_service_director_v2._meta import APP_NAME
7373
from simcore_service_director_v2.constants import DYNAMIC_SIDECAR_SERVICE_PREFIX
7474
from simcore_service_director_v2.core.dynamic_services_settings.sidecar import (
7575
RCloneSettings,
@@ -327,7 +327,7 @@ def workbench_dynamic_services(
327327

328328
@pytest.fixture
329329
async def db_manager(sqlalchemy_async_engine: AsyncEngine) -> DBManager:
330-
return DBManager(sqlalchemy_async_engine)
330+
return DBManager(sqlalchemy_async_engine, application_name=APP_NAME)
331331

332332

333333
def _is_docker_r_clone_plugin_installed() -> bool:
@@ -510,7 +510,7 @@ async def _get_mapped_nodeports_values(
510510
for node_uuid in workbench:
511511
PORTS: Nodeports = await node_ports_v2.ports(
512512
user_id=user_id,
513-
project_id=ProjectIDStr(project_id),
513+
project_id=project_id,
514514
node_uuid=TypeAdapter(NodeIDStr).validate_python(node_uuid),
515515
db_manager=db_manager,
516516
)

0 commit comments

Comments
 (0)