cleanup

Author: pcrespov

packages/service-library/src/servicelib/aiohttp/rest_responses.py

@@ -1,13 +1,12 @@
 """Utils to check, convert and compose server responses for the RESTApi"""
 
 import inspect
-from typing import Any, cast
+from typing import Any
 
 from aiohttp import web, web_exceptions
 from aiohttp.web_exceptions import HTTPError, HTTPException
 from common_library.error_codes import ErrorCodeStr
 from common_library.json_serialization import json_dumps
-from models_library.basic_types import IDStr
 from models_library.rest_error import ErrorGet, ErrorItemType
 from servicelib.rest_constants import RESPONSE_MODEL_POLICY
 
@@ -65,24 +64,26 @@ def create_http_error(
     if not isinstance(errors, list):
         errors = [errors]
 
-    support_id: IDStr | None = cast(IDStr, error_code) if error_code else None
-
     is_internal_error: bool = http_error_cls == web.HTTPInternalServerError
     default_message = reason or get_code_description(http_error_cls.status_code)
 
     if is_internal_error and skip_internal_error_details:
-        error = ErrorGet(
-            status=http_error_cls.status_code,
-            message=default_message,
-            support_id=support_id,
+        error = ErrorGet.model_validate(
+            {
+                "status": http_error_cls.status_code,
+                "message": default_message,
+                "support_id": error_code,
+            }
         )
     else:
         items = [ErrorItemType.from_error(err) for err in errors]
-        error = ErrorGet(
-            errors=items,  # NOTE: deprecated!
-            status=http_error_cls.status_code,
-            message=default_message,
-            support_id=support_id,
+        error = ErrorGet.model_validate(
+            {
+                "errors": items,  # NOTE: deprecated!
+                "status": http_error_cls.status_code,
+                "message": default_message,
+                "support_id": error_code,
+            }
         )
 
     assert not http_error_cls.empty_body  # nosec