Skip to content

Commit 984846e

Browse files
author
Andrei Neagu
committed
fixed ciruclar dependency
1 parent 7d6d885 commit 984846e

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

packages/service-library/src/servicelib/long_running_tasks/_lrt_server.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
11
import traceback
2-
from typing import Any
2+
from typing import TYPE_CHECKING, Any
33

44
from ..rabbitmq import RPCRouter
55
from ._serialization import object_to_string
6-
from .base_long_running_manager import BaseLongRunningManager
76
from .errors import BaseLongRunningError, TaskNotCompletedError, TaskNotFoundError
87
from .models import RPCErrorResponse, TaskBase, TaskContext, TaskId, TaskStatus
98
from .task import RegisteredTaskName
109

10+
if TYPE_CHECKING:
11+
from .base_long_running_manager import BaseLongRunningManager
12+
13+
1114
router = RPCRouter()
1215

1316

1417
@router.expose(reraise_if_error_type=(BaseLongRunningError,))
1518
async def start_task(
16-
long_running_manager: BaseLongRunningManager,
19+
long_running_manager: "BaseLongRunningManager",
1720
*,
1821
registered_task_name: RegisteredTaskName,
1922
unique: bool = False,
@@ -34,7 +37,7 @@ async def start_task(
3437

3538
@router.expose(reraise_if_error_type=(BaseLongRunningError,))
3639
async def list_tasks(
37-
long_running_manager: BaseLongRunningManager, *, task_context: TaskContext
40+
long_running_manager: "BaseLongRunningManager", *, task_context: TaskContext
3841
) -> list[TaskBase]:
3942
return await long_running_manager.tasks_manager.list_tasks(
4043
with_task_context=task_context
@@ -43,7 +46,7 @@ async def list_tasks(
4346

4447
@router.expose(reraise_if_error_type=(BaseLongRunningError,))
4548
async def get_task_status(
46-
long_running_manager: BaseLongRunningManager,
49+
long_running_manager: "BaseLongRunningManager",
4750
*,
4851
task_context: TaskContext,
4952
task_id: TaskId,
@@ -54,7 +57,7 @@ async def get_task_status(
5457

5558

5659
async def _get_transferarble_task_result(
57-
long_running_manager: BaseLongRunningManager,
60+
long_running_manager: "BaseLongRunningManager",
5861
*,
5962
task_context: TaskContext,
6063
task_id: TaskId,
@@ -79,7 +82,7 @@ async def _get_transferarble_task_result(
7982

8083
@router.expose(reraise_if_error_type=(BaseLongRunningError, Exception))
8184
async def get_task_result(
82-
long_running_manager: BaseLongRunningManager,
85+
long_running_manager: "BaseLongRunningManager",
8386
*,
8487
task_context: TaskContext,
8588
task_id: TaskId,
@@ -99,7 +102,7 @@ async def get_task_result(
99102

100103
@router.expose(reraise_if_error_type=(BaseLongRunningError,))
101104
async def remove_task(
102-
long_running_manager: BaseLongRunningManager,
105+
long_running_manager: "BaseLongRunningManager",
103106
*,
104107
task_context: TaskContext,
105108
task_id: TaskId,

packages/service-library/src/servicelib/long_running_tasks/base_long_running_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from settings_library.redis import RedisSettings
55

66
from ..rabbitmq._client_rpc import RabbitMQRPCClient
7+
from ._lrt_server import router
78
from ._rabbit_namespace import get_rabbit_namespace
89
from .models import LRTNamespace
910
from .task import TasksManager
@@ -61,7 +62,6 @@ async def setup(self) -> None:
6162
client_name=f"lrt-client-{self.lrt_namespace}",
6263
settings=self.rabbit_settings,
6364
)
64-
from ._lrt_server import router
6565

6666
await self.rpc_server.register_router(
6767
router,

0 commit comments

Comments
 (0)