test handlers green

Author: sanderegg

services/storage/src/simcore_service_storage/api/rest/_files.py

@@ -287,7 +287,7 @@ async def complete_upload_file(
 
 @router.post(
     "/locations/{location_id}/files/{file_id:path}:complete/futures/{future_id}",
-    response_model=FileUploadCompleteFutureResponse,
+    response_model=Envelope[FileUploadCompleteFutureResponse],
 )
 async def is_completed_upload_file(
     query_params: Annotated[StorageQueryParamsBase, Depends()],
@@ -315,16 +315,18 @@ async def is_completed_upload_file(
             response = FileUploadCompleteFutureResponse(
                 state=FileUploadCompleteState.NOK
             )
-        return response
+        return Envelope[FileUploadCompleteFutureResponse](data=response)
     # there is no task, either wrong call or storage was restarted
     # we try to get the file to see if it exists in S3
     dsm = get_dsm_provider(request.app).get(location_id)
     if fmd := await dsm.get_file(
         user_id=query_params.user_id,
         file_id=file_id,
     ):
-        return FileUploadCompleteFutureResponse(
-            state=FileUploadCompleteState.OK, e_tag=fmd.entity_tag
+        return Envelope[FileUploadCompleteFutureResponse](
+            data=FileUploadCompleteFutureResponse(
+                state=FileUploadCompleteState.OK, e_tag=fmd.entity_tag
+            )
         )
     raise HTTPException(
         status.HTTP_404_NOT_FOUND,

services/storage/src/simcore_service_storage/core/application.py

@@ -96,6 +96,8 @@ def create_app(settings: ApplicationSettings) -> FastAPI:
 
     app.add_middleware(GZipMiddleware)
 
+    app.add_middleware(BaseHTTPMiddleware, dispatch=timing_middleware.log_request)
+
     if settings.STORAGE_TRACING:
         setup_tracing(app, settings.STORAGE_TRACING, APP_NAME)
     if settings.STORAGE_MONITORING_ENABLED:

services/storage/src/simcore_service_storage/utils/utils.py

@@ -68,7 +68,7 @@ def is_file_entry_valid(file_metadata: FileMetaData | FileMetaDataAtDB) -> bool:
 
 
 def create_upload_completion_task_name(user_id: UserID, file_id: StorageFileID) -> str:
-    return f"upload_complete_task_{user_id}_{urllib.parse.quote(file_id, safe='')}"
+    return f"upload_complete_task_{user_id}_{urllib.parse.quote(file_id.replace('/', '_'), safe='')}"
 
 
 def is_valid_managed_multipart_upload(upload_id: UploadID | None) -> bool: