refactor: use Final for application keys to ensure immutability

Author: pcrespov

services/web/server/src/simcore_service_webserver/application_keys.py

@@ -1,6 +1,6 @@
 """web.AppKey definitions for simcore_service_webserver"""
 
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Final
 
 from aiohttp import web
 from servicelib.aiohttp.application_keys import (
@@ -14,11 +14,11 @@
     # Application settings key - defined here to avoid circular imports
     from .application_settings import ApplicationSettings
 
-    APP_SETTINGS_KEY: web.AppKey[ApplicationSettings] = web.AppKey(
+    APP_SETTINGS_KEY: Final[web.AppKey[ApplicationSettings]] = web.AppKey(
         "APP_SETTINGS_KEY", ApplicationSettings
     )
 else:
-    APP_SETTINGS_KEY: web.AppKey = web.AppKey("APP_SETTINGS_KEY", None)
+    APP_SETTINGS_KEY: Final[web.AppKey] = web.AppKey("APP_SETTINGS_KEY", None)
 
 
 __all__: tuple[str, ...] = (

services/web/server/src/simcore_service_webserver/director_v2/_director_v2_abc_service.py

@@ -1,4 +1,5 @@
 from abc import ABC, abstractmethod
+from typing import Final
 
 from aiohttp import web
 from models_library.projects import CommitID, ProjectID
@@ -40,7 +41,9 @@ async def get_or_create_runnable_projects(
     ) -> tuple[list[ProjectID], list[CommitID]]: ...
 
 
-_PROJECT_RUN_POLICY_APPKEY = web.AppKey("PROJECT_RUN_POLICY", AbstractProjectRunPolicy)
+_PROJECT_RUN_POLICY_APPKEY: Final = web.AppKey(
+    "PROJECT_RUN_POLICY", AbstractProjectRunPolicy
+)
 
 
 def get_project_run_policy(app: web.Application) -> AbstractProjectRunPolicy | None:

services/web/server/src/simcore_service_webserver/products/_web_events.py

@@ -12,7 +12,7 @@
 
 _logger = logging.getLogger(__name__)
 
-PRODUCTS_TEMPLATES_DIR_APPKEY = web.AppKey("PRODUCTS_TEMPLATES_DIR", Path)
+PRODUCTS_TEMPLATES_DIR_APPKEY: Final = web.AppKey("PRODUCTS_TEMPLATES_DIR", Path)
 
 
 async def _auto_create_products_groups(app: web.Application) -> None:

services/web/server/src/simcore_service_webserver/scicrunch/service_client.py

@@ -5,6 +5,7 @@
 """
 
 import logging
+from typing import Final
 
 from aiohttp import ClientSession, client_exceptions, web
 from pydantic import HttpUrl, TypeAdapter, ValidationError
@@ -173,4 +174,4 @@ async def search_resource(self, name_as: str) -> list[ResourceHit]:
         return hits.root
 
 
-_SCICRUNCH_APPKEY: web.AppKey = web.AppKey(SciCrunch.__name__, SciCrunch)
+_SCICRUNCH_APPKEY: Final = web.AppKey(SciCrunch.__name__, SciCrunch)