Skip to content

Commit 99a9195

Browse files
committed
refactor
1 parent cdc1e53 commit 99a9195

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

services/static-webserver/client/source/class/osparc/share/Collaborators.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,8 @@ qx.Class.define("osparc.share.Collaborators", {
244244
case "template":
245245
case "tutorial":
246246
case "hypertool":
247+
case "function":
248+
case "tag":
247249
rolesLayout = osparc.data.Roles.createRolesStudyInfo();
248250
break;
249251
case "service":
@@ -252,9 +254,6 @@ qx.Class.define("osparc.share.Collaborators", {
252254
case "workspace":
253255
rolesLayout = osparc.data.Roles.createRolesWorkspaceInfo();
254256
break;
255-
case "tag":
256-
rolesLayout = osparc.data.Roles.createRolesStudyInfo();
257-
break;
258257
}
259258
return rolesLayout;
260259
},

services/static-webserver/client/source/class/osparc/ui/list/CollaboratorListItem.js

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,25 @@ qx.Class.define("osparc.ui.list.CollaboratorListItem", {
7575

7676
members: {
7777
__getRoleInfo: function(id) {
78+
let roleInfo = undefined;
7879
const resource = this.getResourceType();
79-
if (["study", "template", "tutorial", "hypertool"].includes(resource)) {
80-
return osparc.data.Roles.STUDY[id];
81-
} else if (resource === "service") {
82-
return osparc.data.Roles.SERVICES[id];
83-
} else if (resource === "workspace") {
84-
return osparc.data.Roles.WORKSPACE[id];
85-
} else if (resource === "tag") {
86-
return osparc.data.Roles.STUDY[id];
80+
switch (resource) {
81+
case "study":
82+
case "template":
83+
case "tutorial":
84+
case "hypertool":
85+
case "function":
86+
case "tag":
87+
roleInfo = osparc.data.Roles.STUDY[id];
88+
break;
89+
case "service":
90+
roleInfo = osparc.data.Roles.SERVICES[id];
91+
break;
92+
case "workspace":
93+
roleInfo = osparc.data.Roles.WORKSPACE[id];
94+
break;
8795
}
88-
return undefined;
96+
return roleInfo;
8997
},
9098

9199
_createChildControlImpl: function(id) {

0 commit comments

Comments
 (0)