Skip to content

Commit 9b27178

Browse files
committed
removed submit column
1 parent 0f674ad commit 9b27178

File tree

3 files changed

+23
-30
lines changed

3 files changed

+23
-30
lines changed

services/director-v2/src/simcore_service_director_v2/models/comp_tasks.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ class CompTaskAtDB(BaseModel):
128128
description="the hex digest of the resolved inputs +outputs hash at the time when the last outputs were generated",
129129
)
130130
image: Image
131-
submit: dt.datetime
132131
start: dt.datetime | None = None
133132
end: dt.datetime | None = None
134133
state: RunningState
@@ -163,7 +162,7 @@ def _convert_state_from_state_type_enum_if_needed(cls, v):
163162
return RunningState(DB_TO_RUNNING_STATE[StateType(v)])
164163
return v
165164

166-
@field_validator("start", "end", "submit")
165+
@field_validator("start", "end")
167166
@classmethod
168167
def _ensure_utc(cls, v: dt.datetime | None) -> dt.datetime | None:
169168
if v is not None and v.tzinfo is None:
@@ -228,7 +227,6 @@ def to_db_model(self, **exclusion_rules) -> dict[str, Any]:
228227
}
229228
},
230229
"image": image_example,
231-
"submit": "2021-03-01 13:07:34.19161",
232230
"node_class": "INTERACTIVE",
233231
"state": "NOT_STARTED",
234232
"progress": 0.44,

services/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_tasks/_utils.py

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,12 @@ async def _get_node_infos(
145145
None,
146146
)
147147

148-
result: tuple[ServiceMetaDataPublished, ServiceExtras, SimcoreServiceLabels] = (
149-
await asyncio.gather(
150-
_get_service_details(catalog_client, user_id, product_name, node),
151-
director_client.get_service_extras(node.key, node.version),
152-
director_client.get_service_labels(node),
153-
)
148+
result: tuple[
149+
ServiceMetaDataPublished, ServiceExtras, SimcoreServiceLabels
150+
] = await asyncio.gather(
151+
_get_service_details(catalog_client, user_id, product_name, node),
152+
director_client.get_service_extras(node.key, node.version),
153+
director_client.get_service_labels(node),
154154
)
155155
return result
156156

@@ -246,9 +246,9 @@ async def _get_pricing_and_hardware_infos(
246246
return pricing_info, hardware_info
247247

248248

249-
_RAM_SAFE_MARGIN_RATIO: Final[float] = (
250-
0.1 # NOTE: machines always have less available RAM than advertised
251-
)
249+
_RAM_SAFE_MARGIN_RATIO: Final[
250+
float
251+
] = 0.1 # NOTE: machines always have less available RAM than advertised
252252
_CPUS_SAFE_MARGIN: Final[float] = 0.1
253253

254254

@@ -266,11 +266,11 @@ async def _update_project_node_resources_from_hardware_info(
266266
if not hardware_info.aws_ec2_instances:
267267
return
268268
try:
269-
unordered_list_ec2_instance_types: list[EC2InstanceTypeGet] = (
270-
await get_instance_type_details(
271-
rabbitmq_rpc_client,
272-
instance_type_names=set(hardware_info.aws_ec2_instances),
273-
)
269+
unordered_list_ec2_instance_types: list[
270+
EC2InstanceTypeGet
271+
] = await get_instance_type_details(
272+
rabbitmq_rpc_client,
273+
instance_type_names=set(hardware_info.aws_ec2_instances),
274274
)
275275

276276
assert unordered_list_ec2_instance_types # nosec
@@ -439,7 +439,6 @@ async def generate_tasks_list_from_project(
439439
inputs=node.inputs,
440440
outputs=node.outputs,
441441
image=image,
442-
submit=arrow.utcnow().datetime,
443442
state=task_state,
444443
internal_id=internal_id,
445444
node_class=to_node_class(node.key),

services/director-v2/tests/unit/test_utils_dags.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -485,9 +485,8 @@ def pipeline_test_params(
485485
state=RunningState.NOT_STARTED,
486486
internal_id=3,
487487
node_class=NodeClass.COMPUTATIONAL,
488-
submit=datetime.datetime.now(tz=datetime.timezone.utc),
489-
created=datetime.datetime.now(tz=datetime.timezone.utc),
490-
modified=datetime.datetime.now(tz=datetime.timezone.utc),
488+
created=datetime.datetime.now(tz=datetime.UTC),
489+
modified=datetime.datetime.now(tz=datetime.UTC),
491490
last_heartbeat=None,
492491
progress=1.00,
493492
)
@@ -536,9 +535,8 @@ def pipeline_test_params(
536535
state=RunningState.NOT_STARTED,
537536
internal_id=3,
538537
node_class=NodeClass.COMPUTATIONAL,
539-
submit=datetime.datetime.now(tz=datetime.timezone.utc),
540-
created=datetime.datetime.now(tz=datetime.timezone.utc),
541-
modified=datetime.datetime.now(tz=datetime.timezone.utc),
538+
created=datetime.datetime.now(tz=datetime.UTC),
539+
modified=datetime.datetime.now(tz=datetime.UTC),
542540
last_heartbeat=None,
543541
),
544542
CompTaskAtDB.model_construct(
@@ -550,9 +548,8 @@ def pipeline_test_params(
550548
state=RunningState.NOT_STARTED,
551549
internal_id=3,
552550
node_class=NodeClass.COMPUTATIONAL,
553-
submit=datetime.datetime.now(tz=datetime.timezone.utc),
554-
created=datetime.datetime.now(tz=datetime.timezone.utc),
555-
modified=datetime.datetime.now(tz=datetime.timezone.utc),
551+
created=datetime.datetime.now(tz=datetime.UTC),
552+
modified=datetime.datetime.now(tz=datetime.UTC),
556553
last_heartbeat=None,
557554
),
558555
CompTaskAtDB.model_construct(
@@ -564,9 +561,8 @@ def pipeline_test_params(
564561
state=RunningState.NOT_STARTED,
565562
internal_id=3,
566563
node_class=NodeClass.COMPUTATIONAL,
567-
submit=datetime.datetime.now(tz=datetime.timezone.utc),
568-
created=datetime.datetime.now(tz=datetime.timezone.utc),
569-
modified=datetime.datetime.now(tz=datetime.timezone.utc),
564+
created=datetime.datetime.now(tz=datetime.UTC),
565+
modified=datetime.datetime.now(tz=datetime.UTC),
570566
last_heartbeat=None,
571567
progress=1.00,
572568
),

0 commit comments

Comments
 (0)