fix types

Author: sanderegg

services/web/server/src/simcore_service_webserver/garbage_collector/_core_utils.py

@@ -145,9 +145,9 @@ async def replace_current_owner(
         )
         return
 
-    # the result might me none
+    # the result might me none (really? that is not what the function is supposed to do)
     if new_project_owner_id is None:
-        _logger.warning(
+        _logger.warning(  # type: ignore[unreachable]
             "Could not recover a new user id from gid %s", new_project_owner_gid
         )
         return

services/web/server/src/simcore_service_webserver/groups/_groups_repository.py

@@ -312,7 +312,6 @@ async def create_standard_group(
     user_id: UserID,
     create: StandardGroupCreate,
 ) -> tuple[Group, AccessRightsDict]:
-
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
         user = await conn.scalar(
             sa.select(
@@ -358,7 +357,6 @@ async def update_standard_group(
     group_id: GroupID,
     update: StandardGroupUpdate,
 ) -> tuple[Group, AccessRightsDict]:
-
     values = update.model_dump(mode="json", exclude_unset=True)
 
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
@@ -560,12 +558,7 @@ async def update_user_in_group(
     the_user_id_in_group: UserID,
     access_rights: AccessRightsDict,
 ) -> GroupMember:
-    if not access_rights:
-        msg = f"Cannot update empty {access_rights}"
-        raise ValueError(msg)
-
     async with transaction_context(get_asyncpg_engine(app), connection) as conn:
-
         # first check if the group exists
         await _get_group_and_access_rights_or_raise(
             conn, caller_id=caller_id, group_id=group_id, permission="write"
@@ -715,7 +708,6 @@ async def auto_add_user_to_groups(
     *,
     user: dict,
 ) -> None:
-
     user_id: UserID = user["id"]
 
     # auto add user to the groups with the right rules

services/web/server/src/simcore_service_webserver/projects/_projects_repository_legacy.py

@@ -124,11 +124,11 @@
 class ProjectDBAPI(BaseProjectDB):
     def __init__(self, app: web.Application) -> None:
         self._app = app
-        self._engine = cast(Engine, app.get(APP_AIOPG_ENGINE_KEY))
+        self._engine = cast(Engine | None, app.get(APP_AIOPG_ENGINE_KEY))
 
     def _init_engine(self) -> None:
         # Delays creation of engine because it setup_db does it on_startup
-        self._engine = cast(Engine, self._app.get(APP_AIOPG_ENGINE_KEY))
+        self._engine = cast(Engine | None, self._app.get(APP_AIOPG_ENGINE_KEY))
         if self._engine is None:
             msg = "Database subsystem was not initialized"
             raise ValueError(msg)
@@ -435,7 +435,6 @@ def _create_shared_workspace_query(
         is_search_by_multi_columns: bool,
         user_groups: list[GroupID],
     ) -> sql.Select | None:
-
         if workspace_query.workspace_scope is not WorkspaceScope.PRIVATE:
             assert workspace_query.workspace_scope in (  # nosec
                 WorkspaceScope.SHARED,

services/web/server/src/simcore_service_webserver/resource_manager/registry.py

@@ -130,9 +130,6 @@ async def find_resources(
         return resources
 
     async def find_keys(self, resource: tuple[str, str]) -> list[UserSessionDict]:
-        if not resource:
-            return []
-
         field, value = resource
         return [
             self._decode_hash_key(hash_key)

services/web/server/src/simcore_service_webserver/resource_usage/_pricing_plans_admin_service.py

@@ -135,7 +135,7 @@ def _validate_pricing_unit(classification: PricingPlanClassification, unit_extra
             msg = "Expected UnitExtraInfoTier (CPU, RAM, VRAM) for TIER classification"
             raise ValueError(msg)
     else:
-        msg = "Not known pricing plan classification"
+        msg = "Not known pricing plan classification"  # type: ignore[unreachable]
         raise ValueError(msg)
 
 

services/web/server/src/simcore_service_webserver/security/_authz_policy.py

@@ -131,8 +131,8 @@ async def authorized_userid(self, identity: IdentityStr) -> int | None:
 
     async def permits(
         self,
-        identity: IdentityStr,
-        permission: str,
+        identity: IdentityStr | None,
+        permission: str | None,
         context: OptionalContext = None,
     ) -> bool:
         """Implements Interface: Determines whether an identified user has permission