Merge branch 'master' into is7158/icon-services

Author: pcrespov

.github/workflows/ci-testing-pull-request.yml

@@ -39,7 +39,7 @@ jobs:
       - name: Check openapi specs are up to date
         run: |
           if ! ./ci/github/helpers/openapi-specs-diff.bash diff \
-            https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/${{ github.event.after }} \
+            https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/${{ github.event.pull_request.head.sha }} \
             .; then \
             echo "::error:: OAS are not up to date. Run 'make openapi-specs' to update them"; exit 1; \
           fi

services/catalog/src/simcore_service_catalog/models/services_db.py

@@ -7,7 +7,7 @@
 from models_library.services_base import ServiceKeyVersion
 from models_library.services_metadata_editable import ServiceMetaDataEditable
 from models_library.services_types import ServiceKey, ServiceVersion
-from pydantic import AfterValidator, BaseModel, ConfigDict, Field, HttpUrl
+from pydantic import BaseModel, ConfigDict, Field
 from pydantic.config import JsonDict
 from pydantic.types import PositiveInt
 from simcore_postgres_database.models.services_compatibility import CompatiblePolicyDict
@@ -16,12 +16,13 @@
 class ServiceMetaDataAtDB(ServiceKeyVersion, ServiceMetaDataEditable):
     # for a partial update all Editable members must be Optional
     name: str | None = None
-    thumbnail: Annotated[str, HttpUrl] | None = None
-    icon: Annotated[HttpUrl, AfterValidator(str)] | None = None
+    thumbnail: str | None = None
+    icon: str | None = None
     description: str | None = None
 
     classifiers: Annotated[
-        list[str] | None, Field(default_factory=list)
+        list[str] | None,
+        Field(default_factory=list),
     ] = DEFAULT_FACTORY
 
     owner: PositiveInt | None = None

services/web/server/src/simcore_service_webserver/exception_handling/_factory.py

@@ -90,6 +90,8 @@ async def _exception_handler(
                     error=exception,
                     error_code=oec,
                     error_context={
+                        # NOTE: context is also used to substitute tokens in the error message
+                        # e.g. "support error is {error_code}"
                         "request": request,
                         "request.remote": f"{request.remote}",
                         "request.method": f"{request.method}",