Skip to content

Commit 9c98595

Browse files
author
Andrei Neagu
committed
refactored tests
1 parent 41f9a9d commit 9c98595

File tree

4 files changed

+341
-26
lines changed

4 files changed

+341
-26
lines changed

services/dynamic-scheduler/tests/conftest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"pytest_simcore.cli_runner",
2626
"pytest_simcore.docker_compose",
2727
"pytest_simcore.docker_swarm",
28+
"pytest_simcore.docker",
2829
"pytest_simcore.environment_configs",
2930
"pytest_simcore.faker_projects_data",
3031
"pytest_simcore.faker_users_data",
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
from collections.abc import Callable, Iterable
2+
3+
import pytest
4+
from simcore_service_dynamic_scheduler.services.generic_scheduler import (
5+
Operation,
6+
OperationName,
7+
OperationRegistry,
8+
)
9+
10+
11+
@pytest.fixture
12+
def register_operation() -> Iterable[Callable[[OperationName, Operation], None]]:
13+
to_unregister: list[OperationName] = []
14+
15+
def _(opration_name: OperationName, operation: Operation) -> None:
16+
OperationRegistry.register(opration_name, operation)
17+
to_unregister.append(opration_name)
18+
19+
yield _
20+
21+
for opration_name in to_unregister:
22+
OperationRegistry.unregister(opration_name)

services/dynamic-scheduler/tests/unit/service_generic_scheduler/test__core.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
from asgi_lifespan import LifespanManager
1717
from fastapi import FastAPI
1818
from pydantic import NonNegativeInt
19-
from pytest_mock import MockerFixture
2019
from pytest_simcore.helpers.typing_env import EnvVarsDict
2120
from servicelib.utils import limited_gather
2221
from settings_library.rabbit import RabbitSettings
@@ -26,7 +25,6 @@
2625
BaseStep,
2726
Operation,
2827
OperationName,
29-
OperationRegistry,
3028
ParallelStepGroup,
3129
ProvidedOperationContext,
3230
RequiredOperationContext,
@@ -73,16 +71,6 @@
7371
_PARALLEL_APP_CREATION: Final[NonNegativeInt] = 5
7472

7573

76-
@pytest.fixture
77-
def disable_other_generic_scheduler_modules(mocker: MockerFixture) -> None:
78-
# these also use redis
79-
generic_scheduler_module = (
80-
"simcore_service_dynamic_scheduler.services.generic_scheduler"
81-
)
82-
mocker.patch(f"{generic_scheduler_module}._store.lifespan")
83-
mocker.patch(f"{generic_scheduler_module}._core.lifespan")
84-
85-
8674
@pytest.fixture
8775
def app_environment(
8876
disable_postgres_lifespan: None,
@@ -129,20 +117,6 @@ async def selected_app(
129117
return choice(apps)
130118

131119

132-
@pytest.fixture
133-
def register_operation() -> Iterable[Callable[[OperationName, Operation], None]]:
134-
to_unregister: list[OperationName] = []
135-
136-
def _(opration_name: OperationName, operation: Operation) -> None:
137-
OperationRegistry.register(opration_name, operation)
138-
to_unregister.append(opration_name)
139-
140-
yield _
141-
142-
for opration_name in to_unregister:
143-
OperationRegistry.unregister(opration_name)
144-
145-
146120
@pytest.fixture
147121
def operation_name() -> OperationName:
148122
return "test_op"

0 commit comments

Comments
 (0)