fixed issue with serialization

Author: Andrei Neagu

packages/models-library/src/models_library/aiodocker_api.py

@@ -1,4 +1,4 @@
-from pydantic import ConfigDict, Field, field_validator
+from pydantic import Field, field_validator
 
 from .generated_models.docker_rest_api import (
     ContainerSpec,
@@ -7,7 +7,6 @@
     ServiceSpec,
     TaskSpec,
 )
-from .utils.change_case import camel_to_snake
 
 
 class AioDockerContainerSpec(ContainerSpec):
@@ -38,8 +37,6 @@ class AioDockerResources1(Resources1):
         None, description="Define resources reservation.", alias="Reservations"
     )
 
-    model_config = ConfigDict(populate_by_name=True)
-
 
 class AioDockerTaskSpec(TaskSpec):
     container_spec: AioDockerContainerSpec | None = Field(
@@ -51,5 +48,3 @@ class AioDockerTaskSpec(TaskSpec):
 
 class AioDockerServiceSpec(ServiceSpec):
     task_template: AioDockerTaskSpec | None = Field(default=None, alias="TaskTemplate")
-
-    model_config = ConfigDict(populate_by_name=True, alias_generator=camel_to_snake)

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_event_create_sidecars.py

@@ -250,7 +250,9 @@ async def action(cls, app: FastAPI, scheduler_data: SchedulerData) -> None:
         dynamic_sidecar_service_final_spec = AioDockerServiceSpec.model_validate(
             nested_update(
                 jsonable_encoder(dynamic_sidecar_service_spec_base, exclude_unset=True),
-                jsonable_encoder(user_specific_service_spec, exclude_unset=True),
+                jsonable_encoder(
+                    user_specific_service_spec, exclude_unset=True, by_alias=True
+                ),
                 include=_DYNAMIC_SIDECAR_SERVICE_EXTENDABLE_SPECS,
             )
         )

services/director-v2/tests/unit/with_dbs/test_modules_dynamic_sidecar_docker_service_specs.py

@@ -625,3 +625,14 @@ async def test_merge_dynamic_sidecar_specs_with_user_specific_specs(
         ),
     )
     assert another_merged_dict
+
+
+def test_regression_aio_docker_service_spec_serialization():
+    raw_json = json.loads(
+        '{"sidecar":{"Name":null,"Labels":{"io.simcore.scalable-service":"true"},"TaskTemplate":{"PluginSpec":null,"ContainerSpec":null,"NetworkAttachmentSpec":null,"Resources":null,"RestartPolicy":null,"Placement":{"Constraints":["node.labels.io.simcore.autoscaled-node==true","node.labels.io.simcore.osparc-services-ready==true"],"Preferences":null,"MaxReplicas":0,"Platforms":null},"ForceUpdate":null,"Runtime":null,"Networks":null,"LogDriver":null},"Mode":null,"UpdateConfig":null,"RollbackConfig":null,"Networks":null,"EndpointSpec":null},"service":null}'
+    )
+    to_validate = raw_json["sidecar"]
+    result = AioDockerServiceSpec.model_validate(to_validate)
+    assert (
+        result.model_dump(mode="json", exclude_unset=True, by_alias=True) == to_validate
+    )