Skip to content

Commit 9d402dd

Browse files
committed
minors
1 parent 7c1cf01 commit 9d402dd

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,8 @@ qx.Class.define("osparc.desktop.StudyEditor", {
474474
case "DOWNLOAD_STARTED":
475475
propsForm.retrievingPortData(
476476
portId,
477-
osparc.form.renderer.PropForm.RETRIEVE_STATUS.downloading);
477+
osparc.form.renderer.PropForm.RETRIEVE_STATUS.downloading
478+
);
478479
break;
479480
case "DOWNLOAD_FINISHED_SUCCESSFULLY":
480481
propsForm.retrievedPortData(portId, true);

services/static-webserver/client/source/class/osparc/form/renderer/PropForm.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ qx.Class.define("osparc.form.renderer.PropForm", {
565565
},
566566

567567
retrievingPortData: function(portId, status) {
568-
if (!status) {
568+
if (status === undefined) {
569569
status = this.self().RETRIEVE_STATUS.retrieving;
570570
}
571571
if (portId) {
@@ -616,9 +616,6 @@ qx.Class.define("osparc.form.renderer.PropForm", {
616616
},
617617

618618
__setRetrievingStatus: function(status, portId, idx, row) {
619-
const icon = this.self().getIconForStatus(status);
620-
icon.key = portId;
621-
622619
// remove first if any
623620
let children = this._getChildren();
624621
for (let i=0; i<children.length; i++) {
@@ -632,7 +629,8 @@ qx.Class.define("osparc.form.renderer.PropForm", {
632629

633630
const label = this._getLabelFieldChild(portId).child;
634631
if (label && label.isVisible()) {
635-
this._getLabelFieldChild(portId);
632+
const icon = this.self().getIconForStatus(status);
633+
icon.key = portId;
636634
this._addAt(icon, idx, {
637635
row,
638636
column: this.self().GRID_POS.RETRIEVE_STATUS

0 commit comments

Comments
 (0)