Skip to content

Commit 9daa51b

Browse files
committed
fixed bug and added test
1 parent 298a3d3 commit 9daa51b

File tree

1 file changed

+5
-18
lines changed

1 file changed

+5
-18
lines changed

services/director-v2/tests/unit/test_utils_dags.py

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -651,20 +651,6 @@ async def test_compute_pipeline_details(
651651
modified=datetime.datetime.now(tz=datetime.UTC),
652652
last_heartbeat=None,
653653
),
654-
CompTaskAtDB.model_construct(
655-
project_id=uuid4(),
656-
node_id="node_3",
657-
schema=NodeSchema(inputs={}, outputs={}),
658-
inputs=None,
659-
image=Image(name="simcore/services/comp/fake", tag="1.3.4"),
660-
state=RunningState.NOT_STARTED,
661-
internal_id=3,
662-
node_class=NodeClass.COMPUTATIONAL,
663-
created=datetime.datetime.now(tz=datetime.UTC),
664-
modified=datetime.datetime.now(tz=datetime.UTC),
665-
last_heartbeat=None,
666-
progress=1.00,
667-
),
668654
],
669655
PipelineDetails.model_construct(
670656
adjacency_list={
@@ -683,19 +669,20 @@ async def test_compute_pipeline_details(
683669
),
684670
},
685671
),
686-
id="proper dag",
672+
id="dag with missing tasks (node 3 is missing, so it is not skipped in the pipeline details)",
687673
)
688674
],
689675
)
676+
@pytest.mark.acceptance_test(
677+
"For https://github.com/ITISFoundation/osparc-simcore/issues/8172"
678+
)
690679
async def test_compute_pipeline_details_with_missing_tasks(
691680
pipeline_test_params: PipelineDetailsTestParams,
692681
):
693-
# remove one task
694-
incomplete_comp_tasks = pipeline_test_params.comp_tasks[:-1]
695682
received_details = await compute_pipeline_details(
696683
pipeline_test_params.complete_dag,
697684
pipeline_test_params.pipeline_dag,
698-
incomplete_comp_tasks,
685+
pipeline_test_params.comp_tasks,
699686
)
700687
assert (
701688
received_details.model_dump()

0 commit comments

Comments
 (0)