Skip to content

Commit 9de2c25

Browse files
fix unit tests
1 parent 2656b3d commit 9de2c25

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

services/efs-guardian/tests/unit/test_efs_removal_policy_task.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,11 @@ async def project_in_db(
102102
yield row
103103

104104

105+
@patch("simcore_service_efs_guardian.services.background_tasks.get_redis_lock_client")
105106
@patch("simcore_service_efs_guardian.services.background_tasks.lock_project")
106107
async def test_efs_removal_policy_task(
107108
mock_lock_project: MagicMock,
109+
mock_get_redis_lock_client: MagicMock,
108110
faker: Faker,
109111
app: FastAPI,
110112
efs_cleanup: None,
@@ -167,6 +169,7 @@ async def test_efs_removal_policy_task(
167169

168170
# 5. Now removal policy should remove those data
169171
await removal_policy_task(app)
170-
assert mock_lock_project.called
172+
assert mock_lock_project.assert_called_once
173+
assert mock_get_redis_lock_client.assert_called_once
171174
projects_list = await efs_manager.list_projects_across_whole_efs()
172175
assert projects_list == []

services/web/server/src/simcore_service_webserver/projects/exceptions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
"""Defines the different exceptions that may arise in the projects subpackage"""
2-
2+
# mypy: disable-error-code=truthy-function
33
from typing import Any
44

55
from models_library.projects import ProjectID

services/web/server/tests/unit/with_dbs/02/test_project_lock.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
from models_library.projects_state import ProjectLocked, ProjectStatus
1414
from models_library.users import UserID
1515
from pydantic import parse_raw_as
16+
from simcore_service_webserver.projects.exceptions import ProjectLockError
1617
from simcore_service_webserver.projects.lock import (
1718
PROJECT_REDIS_LOCK_KEY,
18-
ProjectLockError,
1919
get_project_locked_state,
2020
is_project_locked,
2121
lock_project,

0 commit comments

Comments
 (0)