refactor

Author: odeimaiz

services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js

@@ -319,14 +319,9 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
       this._addToLayout(resourcesContainer);
     },
 
-    __groupByChanged: function(groupBy) {
+    _groupByChanged: function(groupBy) {
       this._resourcesContainer.setGroupBy(groupBy);
       this._reloadCards();
-
-      const isTemplate = this._resourceType === "template";;
-      if (this._resourceFilter && isTemplate) {
-        this._resourceFilter.getChildControl("tags-layout").setVisibility(isTemplate && groupBy === "tags" ? "visible" : "excluded");
-      }
     },
 
     __viewModeChanged: function(viewMode) {
@@ -353,14 +348,14 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
 
       const dontGroup = new qx.ui.menu.RadioButton(this.tr("None"));
       osparc.utils.Utils.setIdToWidget(dontGroup, "groupByNone");
-      dontGroup.addListener("execute", () => this.__groupByChanged(null));
+      dontGroup.addListener("execute", () => this._groupByChanged(null));
 
       groupByMenu.add(dontGroup);
       groupOptions.add(dontGroup);
 
       if (this._resourceType === "template") {
         const groupByTag = new qx.ui.menu.RadioButton(this.tr("Tags"));
-        groupByTag.addListener("execute", () => this.__groupByChanged("tags"));
+        groupByTag.addListener("execute", () => this._groupByChanged("tags"));
         groupByMenu.add(groupByTag);
         groupOptions.add(groupByTag);
         if (
@@ -372,15 +367,15 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
         }
       } else if (this._resourceType === "service" && osparc.product.Utils.groupServices()) {
         const groupByFeatured = new qx.ui.menu.RadioButton(this.tr("Featured"));
-        groupByFeatured.addListener("execute", () => this.__groupByChanged("groupedServices"));
+        groupByFeatured.addListener("execute", () => this._groupByChanged("groupedServices"));
         groupByMenu.add(groupByFeatured);
         groupOptions.add(groupByFeatured);
         groupByFeatured.execute();
         groupByButton.exclude(); // don't let users change the grouping
       }
 
       const groupByShared = new qx.ui.menu.RadioButton(this.tr("Shared with"));
-      groupByShared.addListener("execute", () => this.__groupByChanged("shared"));
+      groupByShared.addListener("execute", () => this._groupByChanged("shared"));
       groupByMenu.add(groupByShared);
       groupOptions.add(groupByShared);
 

services/static-webserver/client/source/class/osparc/dashboard/TutorialBrowser.js

@@ -118,6 +118,15 @@ qx.Class.define("osparc.dashboard.TutorialBrowser", {
       osparc.filter.UIFilterController.dispatch("searchBarFilter");
     },
 
+    // overridden
+    _groupByChanged: function(groupBy) {
+      this.base(arguments, groupBy);
+
+      if (this._resourceFilter) {
+        this._resourceFilter.getChildControl("tags-layout").setVisibility(groupBy === "tags" ? "visible" : "excluded");
+      }
+    },
+
     __itemClicked: function(card) {
       if (!card.getBlocked()) {
         const templateData = this.__getTemplateData(card.getUuid());