Skip to content

Commit 9feda01

Browse files
committed
✨ update WEBSERVER_REALTIME_COLLABORATION setting and adjust related tests
1 parent 36639a4 commit 9feda01

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

.env-devel

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,8 +395,7 @@ WEBSERVER_PROJECTS={}
395395
WEBSERVER_PROMETHEUS_API_VERSION=v1
396396
WEBSERVER_PROMETHEUS_URL=http://prometheus:9090
397397
WEBSERVER_PUBLICATIONS=1
398-
# WEBSERVER_REALTIME_COLLABORATION='{"RTC_MAX_NUMBER_OF_USERS":3}'
399-
WEBSERVER_REALTIME_COLLABORATION=null
398+
WEBSERVER_REALTIME_COLLABORATION='{"RTC_MAX_NUMBER_OF_USERS":3}'
400399
WEBSERVER_SCICRUNCH={}
401400
WEBSERVER_SESSION_SECRET_KEY='REPLACE_ME_with_result__Fernet_generate_key='
402401
WEBSERVER_SOCKETIO=1

services/web/server/tests/unit/isolated/test_application_settings.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def test_settings_to_client_statics(app_settings: ApplicationSettings):
6565
# special alias
6666
assert statics["stackName"] == "master-simcore"
6767
assert statics["pluginsDisabled"] == [
68-
"WEBSERVER_REALTIME_COLLABORATION",
6968
"WEBSERVER_META_MODELING",
7069
"WEBSERVER_VERSION_CONTROL",
7170
]
@@ -74,13 +73,14 @@ def test_settings_to_client_statics(app_settings: ApplicationSettings):
7473
def test_settings_to_client_statics_plugins(
7574
mock_webserver_service_environment: EnvVarsDict, monkeypatch: pytest.MonkeyPatch
7675
):
76+
monkeypatch.delenv("WEBSERVER_REALTIME_COLLABORATION", raising=False)
77+
7778
# explicitly disable these plugins
7879
disable_plugins = {
7980
"WEBSERVER_EXPORTER",
8081
"WEBSERVER_SCICRUNCH",
8182
"WEBSERVER_META_MODELING",
8283
"WEBSERVER_VERSION_CONTROL",
83-
"WEBSERVER_REALTIME_COLLABORATION",
8484
}
8585
for name in disable_plugins:
8686
monkeypatch.setenv(name, "null")
@@ -89,11 +89,10 @@ def test_settings_to_client_statics_plugins(
8989
monkeypatch.setenv("WEBSERVER_FOLDERS", "0")
9090
disable_plugins.add("WEBSERVER_FOLDERS")
9191

92-
# set WEBSERVER_REALTIME_COLLABORATION (NOTE: WEBSERVER_DEV_FEATURES_ENABLED=True) )
92+
# set WEBSERVER_REALTIME_COLLABORATION (NOTE: for now WEBSERVER_DEV_FEATURES_ENABLED=True) )
9393
monkeypatch.setenv(
9494
"WEBSERVER_REALTIME_COLLABORATION", '{"RTC_MAX_NUMBER_OF_USERS":3}'
9595
)
96-
disable_plugins.remove("WEBSERVER_REALTIME_COLLABORATION")
9796

9897
settings = ApplicationSettings.create_from_envs()
9998
assert settings.WEBSERVER_DEV_FEATURES_ENABLED

0 commit comments

Comments
 (0)