unifies get_product_data

Author: pcrespov

services/web/server/src/simcore_service_webserver/statics/_events.py

@@ -100,6 +100,10 @@ def _get_release_notes_vtag(vtag: str) -> str:
     return f"v{version.major}.{version.minor}.0"
 
 
+def _get_product_data(product: Product) -> dict[str, Any]:
+    return {snake_to_camel(k): v for k, v in product.to_statics().items()}
+
+
 async def create_and_cache_statics_json(app: web.Application) -> None:
     # NOTE: in devel model, the folder might be under construction
     # (qx-compile takes time), therefore we create statics.json
@@ -124,8 +128,7 @@ async def create_and_cache_statics_json(app: web.Application) -> None:
 
         _logger.debug("Product %s", product.name)
 
-        product_data = {snake_to_camel(k): v for k, v in product.to_statics().items()}
-        data.update(product_data)
+        data.update(_get_product_data(product))
 
         # Adds specifics to login settings
         if (p := product.login_settings) and (v := p.get("LOGIN_2FA_REQUIRED", None)):

services/web/server/tests/unit/isolated/products/test_products_model.py

@@ -13,7 +13,6 @@
 from faker import Faker
 from models_library.basic_regex import TWILIO_ALPHANUMERIC_SENDER_ID_RE
 from models_library.products import ProductName
-from models_library.utils.change_case import snake_to_camel
 from pydantic import BaseModel, ValidationError
 from pytest_simcore.helpers.faker_factories import random_product
 from pytest_simcore.pydantic_models import (
@@ -22,6 +21,7 @@
 )
 from simcore_postgres_database.models.products import products as products_table
 from simcore_service_webserver.products.models import Product
+from simcore_service_webserver.statics._events import _get_product_data
 
 
 @pytest.mark.parametrize(
@@ -49,15 +49,15 @@ def test_all_products_models_examples(
 def test_product_to_static():
 
     product = Product.model_validate(Product.model_json_schema()["examples"][0])
-    product_data = {snake_to_camel(k): v for k, v in product.to_statics().items()}
+    product_data = _get_product_data(product)
     assert product_data == {
         "displayName": "o²S²PARC",
         "supportEmail": "[email protected]",
     }
 
     product = Product.model_validate(Product.model_json_schema()["examples"][2])
 
-    product_data = {snake_to_camel(k): v for k, v in product.to_statics().items()}
+    product_data = _get_product_data(product)
     assert product_data == {
         "displayName": "o²S²PARC FOO",
         "supportEmail": "[email protected]",