Skip to content

Commit a241736

Browse files
committed
fix cleanup
1 parent 991ef3f commit a241736

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/service-library/src/servicelib/socketio_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
""" Common utilities for python-socketio library
1+
"""Common utilities for python-socketio library
22
33
44
NOTE: we intentionally avoided importing socketio here to avoid adding an extra dependency at
@@ -9,7 +9,6 @@
99

1010

1111
async def cleanup_socketio_async_pubsub_manager(server_manager):
12-
1312
# NOTE: this is ugly. It seems though that python-socketio does not
1413
# cleanup its background tasks properly.
1514
# https://github.com/miguelgrinberg/python-socketio/discussions/1092
@@ -35,6 +34,7 @@ async def cleanup_socketio_async_pubsub_manager(server_manager):
3534
for coro_name in [
3635
"AsyncServer._service_task",
3736
"AsyncSocket.schedule_ping",
37+
"AsyncSocket._send_ping",
3838
"AsyncPubSubManager._thread",
3939
]
4040
):

0 commit comments

Comments
 (0)