Skip to content

Commit a260cee

Browse files
committed
ensure log stack level is correct + do not fix to INFO level
1 parent 0231c39 commit a260cee

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

packages/pytest-simcore/src/pytest_simcore/helpers/logging_tools.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ def setup(cls, logger: logging.Logger) -> None:
8181
_handler = logging.StreamHandler()
8282
_handler.setFormatter(_formatter)
8383
logger.addHandler(_handler)
84-
logger.setLevel(logging.INFO)
8584

8685

8786
test_logger = logging.getLogger(__name__)
@@ -95,6 +94,7 @@ def setup(cls, logger: logging.Logger) -> None:
9594
_DONE_SUFFIX: Final[str] = " ✅"
9695
_RAISED_PREFIX: Final[str] = "❌❌❌ Error: "
9796
_RAISED_SUFFIX: Final[str] = " ❌❌❌"
97+
_STACK_LEVEL_OFFSET: Final[int] = 3
9898

9999

100100
@dataclass
@@ -170,25 +170,28 @@ def log_context(
170170
_resolve(ctx_msg.starting, _STARTING_PREFIX, _STARTING_SUFFIX),
171171
*args,
172172
**kwargs,
173+
stacklevel=_STACK_LEVEL_OFFSET,
173174
)
174175
with _increased_logger_indent(logger):
175176
yield SimpleNamespace(logger=logger, messages=ctx_msg)
176177
elapsed_time = datetime.datetime.now(tz=datetime.UTC) - started_time
177-
done_message = f"{_resolve(ctx_msg.done, _DONE_PREFIX, _DONE_SUFFIX)} ({_timedelta_as_minute_second_ms(elapsed_time)})"
178+
done_message = f"{_resolve(ctx_msg.done, _DONE_PREFIX, _DONE_SUFFIX)} (total time spent: {_timedelta_as_minute_second_ms(elapsed_time)})"
178179
logger.log(
179180
level,
180181
done_message,
181182
*args,
182183
**kwargs,
184+
stacklevel=_STACK_LEVEL_OFFSET,
183185
)
184186

185187
except:
186188
elapsed_time = datetime.datetime.now(tz=datetime.UTC) - started_time
187-
error_message = f"{_resolve(ctx_msg.raised, _RAISED_PREFIX, _RAISED_SUFFIX)} ({_timedelta_as_minute_second_ms(elapsed_time)})"
189+
error_message = f"{_resolve(ctx_msg.raised, _RAISED_PREFIX, _RAISED_SUFFIX)} (total time spent: {_timedelta_as_minute_second_ms(elapsed_time)})"
188190
logger.exception(
189191
error_message,
190192
*args,
191193
**kwargs,
194+
stacklevel=_STACK_LEVEL_OFFSET,
192195
)
193196
raise
194197

0 commit comments

Comments
 (0)