canItBeOpened

Author: odeimaiz

services/static-webserver/client/source/class/osparc/workbench/ServiceCatalog.js

@@ -82,7 +82,22 @@ qx.Class.define("osparc.workbench.ServiceCatalog", {
   statics: {
     LATEST: "latest",
     Width: 580,
-    Height: 500
+    Height: 500,
+
+    canItBeOpened: function(study) {
+      if (study) {
+        if (study.isReadOnly()) {
+          osparc.FlashMessenger.logError("Nodes can't be added to a read-only project");
+          return false;
+        }
+        if (study.isPipelineRunning()) {
+          osparc.FlashMessenger.logError(osparc.data.model.Workbench.CANT_ADD_NODE);
+          return false;
+        }
+        return true;
+      }
+      return false;
+    },
   },
 
   members: {

services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js

@@ -293,29 +293,25 @@ qx.Class.define("osparc.workbench.WorkbenchUI", {
     },
 
     openServiceCatalog: function(nodePos) {
-      if (this.getStudy().isReadOnly()) {
-        return null;
-      }
-      if (this.getStudy().isPipelineRunning()) {
-        osparc.FlashMessenger.logError(osparc.data.model.Workbench.CANT_ADD_NODE);
-        return null;
+      if (osparc.workbench.ServiceCatalog.canItBeOpened(this.getStudy())) {
+        const srvCat = new osparc.workbench.ServiceCatalog();
+        srvCat.addListener("addService", async e => {
+          const {
+            service,
+            nodeLeftId,
+            nodeRightId
+          } = e.getData();
+          const nodeUI = await this.__addNode(service, nodePos);
+          if (nodeUI && nodeLeftId !== null || nodeRightId !== null) {
+            const newNodeId = nodeUI.getNodeId();
+            this._createEdgeBetweenNodes(nodeLeftId ? nodeLeftId : newNodeId, nodeRightId ? nodeRightId : newNodeId, true);
+          }
+        }, this);
+        srvCat.center();
+        srvCat.open();
+        return srvCat;
       }
-      const srvCat = new osparc.workbench.ServiceCatalog();
-      srvCat.addListener("addService", async e => {
-        const {
-          service,
-          nodeLeftId,
-          nodeRightId
-        } = e.getData();
-        const nodeUI = await this.__addNode(service, nodePos);
-        if (nodeUI && nodeLeftId !== null || nodeRightId !== null) {
-          const newNodeId = nodeUI.getNodeId();
-          this._createEdgeBetweenNodes(nodeLeftId ? nodeLeftId : newNodeId, nodeRightId ? nodeRightId : newNodeId, true);
-        }
-      }, this);
-      srvCat.center();
-      srvCat.open();
-      return srvCat;
+      return null;
     },
 
     __createTemporaryNodeUI: function(pos) {