🐛 Fix exception handling to use safe status messages and improve error response clarity

Author: pcrespov

packages/service-library/src/servicelib/aiohttp/rest_responses.py

@@ -133,13 +133,19 @@ def create_http_error(
     )
 
 
-def exception_to_response(exc: HTTPError) -> web.Response:
+def exception_to_response(exception: HTTPError) -> web.Response:
     # Returning web.HTTPException is deprecated so here we have a converter to a response
     # so it can be used as
     # SEE https://github.com/aio-libs/aiohttp/issues/2415
+
+    if exception.reason:
+        reason = safe_status_message(exception.reason)
+    else:
+        reason = get_code_description(exception.status)
+
     return web.Response(
-        status=exc.status,
-        headers=exc.headers,
-        reason=exc.reason,
-        text=exc.text,
+        status=exception.status,
+        headers=exception.headers,
+        reason=reason,
+        text=exception.text,
     )

services/web/server/src/simcore_service_webserver/exception_handling/_factory.py

@@ -5,10 +5,13 @@
 from common_library.error_codes import create_error_code
 from common_library.json_serialization import json_dumps
 from models_library.rest_error import ErrorGet
-from servicelib.aiohttp.rest_responses import safe_status_message
 from servicelib.aiohttp.web_exceptions_extension import get_all_aiohttp_http_exceptions
 from servicelib.logging_errors import create_troubleshootting_log_kwargs
-from servicelib.status_codes_utils import is_5xx_server_error, is_error
+from servicelib.status_codes_utils import (
+    get_code_description,
+    is_5xx_server_error,
+    is_error,
+)
 
 from ._base import AiohttpExceptionHandler, ExceptionHandlersMap
 
@@ -50,7 +53,7 @@ def create_error_response(error: ErrorGet, status_code: int) -> web.Response:
     return web.json_response(
         data={"error": error.model_dump(exclude_unset=True, mode="json")},
         dumps=json_dumps,
-        reason=safe_status_message(error.message),
+        reason=get_code_description(status_code),
         status=status_code,
     )