Skip to content

Commit a5143f5

Browse files
committed
do not silence exceptions in this PR
1 parent caac2bd commit a5143f5

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

packages/service-library/src/servicelib/logging_utils.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -554,13 +554,12 @@ def log_catch(logger: logging.Logger, *, reraise: bool = True) -> Iterator[None]
554554
logger.debug("call was cancelled")
555555
raise
556556
except Exception as exc: # pylint: disable=broad-except
557-
if not reraise:
558-
logger.exception(
559-
**create_troubleshootting_log_kwargs(
560-
"Caught unhandled exception",
561-
error=exc,
562-
)
557+
logger.exception(
558+
**create_troubleshootting_log_kwargs(
559+
"Caught unhandled exception",
560+
error=exc,
563561
)
562+
)
564563
if reraise:
565564
raise exc from exc
566565

0 commit comments

Comments
 (0)