fix required registry URL

Author: sanderegg

services/director-v2/tests/conftest.py

@@ -186,6 +186,7 @@ def mock_env(
             "REGISTRY_PW": "test",
             "REGISTRY_SSL": "false",
             "REGISTRY_USER": "test",
+            "REGISTRY_URL": faker.url(),
             "SC_BOOT_MODE": "production",
             "SIMCORE_SERVICES_NETWORK_NAME": "test_network_name",
             "SWARM_STACK_NAME": "pytest-simcore",

services/dynamic-sidecar/.env-devel

@@ -22,7 +22,7 @@ DY_SIDECAR_RUN_ID=1689771013_f7c1bd87-4da5-4709-9471-3d60c8a70639
 DY_SIDECAR_USER_SERVICES_HAVE_INTERNET_ACCESS=false
 
 # DOCKER REGISTRY
-DY_DEPLOYMENT_REGISTRY_SETTINGS='{"REGISTRY_AUTH":"false","REGISTRY_USER":"test","REGISTRY_PW":"test","REGISTRY_SSL":"false"}'
+DY_DEPLOYMENT_REGISTRY_SETTINGS='{"REGISTRY_AUTH":"false","REGISTRY_USER":"test","REGISTRY_PW":"test","REGISTRY_SSL":"false", "REGISTRY_URL": "fake.registry.com"}'
 
 S3_ENDPOINT=http://111.111.111.111:12345
 S3_ACCESS_KEY=mocked

services/dynamic-sidecar/tests/conftest.py

@@ -197,6 +197,7 @@ def base_mock_envs(
                 "REGISTRY_USER": "test",
                 "REGISTRY_PW": "test",
                 "REGISTRY_SSL": "false",
+                "REGISTRY_URL": "registry.pytest.com",
             }
         ),
         "DYNAMIC_SIDECAR_TRACING": "null",
@@ -267,6 +268,7 @@ def mock_environment(
                     "REGISTRY_USER": "test",
                     "REGISTRY_PW": "test",
                     "REGISTRY_SSL": "false",
+                    "REGISTRY_URL": "registry.pytest.com",
                 }
             ),
         },

services/dynamic-sidecar/tests/unit/test_core_external_dependencies.py

@@ -59,10 +59,11 @@ def mock_environment(
             "POSTGRES_USER": "test",
             "POSTGRES_PASSWORD": "test",
             "POSTGRES_DB": "test",
-            "REGISTRY_AUTH": "0",
-            "REGISTRY_USER": "test",
-            "REGISTRY_PW": "test",
-            "REGISTRY_SSL": "0",
+            "REGISTRY_AUTH": f"{faker.pybool()}",
+            "REGISTRY_USER": faker.user_name(),
+            "REGISTRY_PW": faker.password(),
+            "REGISTRY_SSL": f"{faker.pybool()}",
+            "REGISTRY_URL": faker.url(),
             **base_mock_envs,
         },
     )