splits tests

Author: pcrespov

packages/models-library/src/models_library/api_schemas_webserver/users.py

@@ -169,7 +169,7 @@ def _validate_user_name(cls, value: str):
 
         # Ensure it doesn't end with a special character
         if {value[0], value[-1]}.intersection({"_", "-", "."}):
-            msg = f"Username '{value}' cannot end or start with a special character."
+            msg = f"Username '{value}' cannot end with a special character."
             raise ValueError(msg)
 
         # Check reserved words (example list; extend as needed)

services/web/server/tests/unit/isolated/test_users_models.py

@@ -187,21 +187,56 @@ def test_mapping_update_models_from_rest_to_db():
     }
 
 
-def test_my_profile_patch_username_validation():
+def test_my_profile_patch_username_min_len():
     # minimum length username is 4
     with pytest.raises(ValidationError) as err_info:
         MyProfilePatch.model_validate({"userName": "abc"})
 
     assert err_info.value.error_count() == 1
     assert err_info.value.errors()[0]["type"] == "too_short"
 
-    MyProfilePatch.model_validate({"userName": "abcd"})
+    MyProfilePatch.model_validate({"userName": "abcd"})  # OK
 
+
+def test_my_profile_patch_username_valid_characters():
     # Ensure valid characters (alphanumeric + . _ -)
     with pytest.raises(ValidationError, match="start with a letter") as err_info:
         MyProfilePatch.model_validate({"userName": "1234"})
 
     assert err_info.value.error_count() == 1
     assert err_info.value.errors()[0]["type"] == "value_error"
 
-    MyProfilePatch.model_validate({"userName": "u1234"})
+    MyProfilePatch.model_validate({"userName": "u1234"})  # OK
+
+
+def test_my_profile_patch_username_special_characters():
+    # Ensure no consecutive special characters
+    with pytest.raises(
+        ValidationError, match="consecutive special characters"
+    ) as err_info:
+        MyProfilePatch.model_validate({"userName": "u1__234"})
+
+    assert err_info.value.error_count() == 1
+    assert err_info.value.errors()[0]["type"] == "value_error"
+
+    MyProfilePatch.model_validate({"userName": "u1_234"})  # OK
+
+    # Ensure it doesn't end with a special character
+    with pytest.raises(ValidationError, match="end with") as err_info:
+        MyProfilePatch.model_validate({"userName": "u1234_"})
+
+    assert err_info.value.error_count() == 1
+    assert err_info.value.errors()[0]["type"] == "value_error"
+
+    MyProfilePatch.model_validate({"userName": "u1_234"})  # OK
+
+
+def test_my_profile_patch_username_reserved_words():
+    # Check reserved words (example list; extend as needed)
+    with pytest.raises(ValidationError, match="cannot be used") as err_info:
+        MyProfilePatch.model_validate({"userName": "admin"})
+
+    assert err_info.value.error_count() == 1
+    assert err_info.value.errors()[0]["type"] == "value_error"
+
+    MyProfilePatch.model_validate({"userName": "midas"})  # OK