add comment

giancarloromeo · giancarloromeo · commit a71c71876921 · 2024-12-13T11:24:37.000+01:00
diff --git a/services/storage/src/simcore_service_storage/simcore_s3_dsm.py b/services/storage/src/simcore_service_storage/simcore_s3_dsm.py
@@ -535,6 +535,8 @@ async def delete_file(
             )
         except S3KeyNotFoundError:
             _logger.warning("File %s not found in S3", file_id)
+            # we still need to clean up the database entry (it exists)
+            # and to invalidate the size of the parent directory
 
         async with self.engine.acquire() as conn:
             await db_file_meta_data.delete(conn, [file_id])

Original file line number	Diff line number	Diff line change
`@@ -535,6 +535,8 @@ async def delete_file(`
`535`	`535`	`)`
`536`	`536`	`except S3KeyNotFoundError:`
`537`	`537`	`_logger.warning("File %s not found in S3", file_id)`
	`538`	`+ # we still need to clean up the database entry (it exists)`
	`539`	`+ # and to invalidate the size of the parent directory`
`538`	`540`
`539`	`541`	`async with self.engine.acquire() as conn:`
`540`	`542`	`await db_file_meta_data.delete(conn, [file_id])`