properly extracted internals

Author: Andrei Neagu

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers_extension.py

@@ -10,10 +10,9 @@
 from simcore_sdk.node_ports_v2.port_utils import is_file_type
 
 from ...core.docker_utils import docker_client
-from ...modules.inputs import disable_inputs_pulling, enable_inputs_pulling
 from ...modules.mounted_fs import MountedVolumes
 from ...modules.outputs import OutputsContext
-from ...services.outputs import disable_event_propagation, enable_event_propagation
+from ...services import container_extensions
 from ._dependencies import get_application, get_mounted_volumes, get_outputs_context
 
 _logger = logging.getLogger(__name__)
@@ -56,15 +55,11 @@ async def toggle_ports_io(
     patch_ports_io_item: PatchPortsIOItem,
     app: Annotated[FastAPI, Depends(get_application)],
 ) -> None:
-    if patch_ports_io_item.enable_outputs:
-        await enable_event_propagation(app)
-    else:
-        await disable_event_propagation(app)
-
-    if patch_ports_io_item.enable_inputs:
-        enable_inputs_pulling(app)
-    else:
-        disable_inputs_pulling(app)
+    await container_extensions.toggle_ports_io(
+        app,
+        enable_outputs=patch_ports_io_item.enable_outputs,
+        enable_inputs=patch_ports_io_item.enable_inputs,
+    )
 
 
 @router.post(

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rpc/_containers_extension.py

@@ -1,8 +1,7 @@
 from fastapi import FastAPI
 from servicelib.rabbitmq import RPCRouter
 
-from ...modules.inputs import disable_inputs_pulling, enable_inputs_pulling
-from ...services.outputs import disable_event_propagation, enable_event_propagation
+from ...services import container_extensions
 
 router = RPCRouter()
 
@@ -11,12 +10,6 @@
 async def toggle_ports_io(
     app: FastAPI, *, enable_outputs: bool, enable_inputs: bool
 ) -> None:
-    if enable_outputs:
-        await enable_event_propagation(app)
-    else:
-        await disable_event_propagation(app)
-
-    if enable_inputs:
-        enable_inputs_pulling(app)
-    else:
-        disable_inputs_pulling(app)
+    await container_extensions.toggle_ports_io(
+        app, enable_outputs=enable_outputs, enable_inputs=enable_inputs
+    )

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/services/container_extensions.py

@@ -0,0 +1,18 @@
+from fastapi import FastAPI
+
+from ..modules.inputs import disable_inputs_pulling, enable_inputs_pulling
+from ..modules.outputs import disable_event_propagation, enable_event_propagation
+
+
+async def toggle_ports_io(
+    app: FastAPI, *, enable_outputs: bool, enable_inputs: bool
+) -> None:
+    if enable_outputs:
+        await enable_event_propagation(app)
+    else:
+        await disable_event_propagation(app)
+
+    if enable_inputs:
+        enable_inputs_pulling(app)
+    else:
+        disable_inputs_pulling(app)